Merged
Conversation
frenck
approved these changes
Nov 9, 2024
Member
Author
|
The tests for 3.13 pass as well (in the 3.13 PR): https://github.com/home-assistant/core/actions/runs/11759616361/job/32759371921?pr=129442#step:10:48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Addresses flaky modbus test behavior on Python 3.13 discovered in #129442.
Background
Python 3.13 changed the event loop scheduler slightly. Under specific circumstances, this caused the
async_updatemethod to be run which wouldn't be execute in time for 3.12 to hit thecaplog.text == ""assert. Thus the error that also exists on 3.12 just wouldn't be shown.The error was emitted here:
core/homeassistant/components/modbus/entity.py
Lines 230 to 240 in 0fc0193
The register values are converted to a
2bytes long byte and according to the error message a byte buffer of size 2 is expected. Therefore theregister_wordsfixture should probably only contain one byte to begin with.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: