Add Volkswagen WeConnect integration#127744
Add Volkswagen WeConnect integration#127744krzysdabro wants to merge 9 commits intohome-assistant:devfrom
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
@autinerd Thank you for the review. I have fix the issues and included link to library in description. |
joostlek
left a comment
joostlek
left a comment
There was a problem hiding this comment.
This library is scraping the web and that is not allowed via ADR-004. The exception states that every field should be queried at the same time, thus that means we should not use regex. Have a check at https://github.com/joostlek/python-volkswagen, we use the build in HTML parser and that is allowed in Home Assistant
|
@joostlek As far as I know, this library actually uses the JSON API for the data updates, as you can see here and here. he only time it interacts with the web application is during the authentication process, which, from my understanding, is allowed under ADR-004. While I must admit your library offers a much cleaner solution for the authentication process, it doesn’t provide further data on the vehicles. What would you suggest as the solution here? |
|
I know, I am also not saying that my library is the way to go, its just that authentication like that would be accepted, but auth like in this PR would not, since it uses regex parsing |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
FYI I have created a PR to refactor auth in the lib: tillsteinbach/WeConnect-python#223 |
krzysdabro
force-pushed
the
weconnect
branch
3 times, most recently
from
3e924e6 to
e02affa
Compare
|
@joostlek The authentication process in the library has been refactored to use HTML parsing. I've upgraded the package, updated the translations, and added a quality scale checklist. Could you take a look when you have some spare time? |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
3 participants
Proposed change
This PR adds integration for Volkswagen WeConnect service using WeConnect-python library.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: