Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Once again, I'm not sure whether it makes sense to add a new widget, router and handler for this, since everything is so similar with the existing ones.
There was a problem hiding this comment.
What would be your suggestion instead?
There was a problem hiding this comment.
I mean the widget shows similar data to system-resources and health-monitoring. But at the same time it shows other data as well and it also has an option to choose a system
There was a problem hiding this comment.
I mean the widget shows similar data to system-resources and health-monitoring. But at the same time it shows other data as well and it also has an option to choose a system
To decide that, we need to know the differences between them.
What other data does it show? Remember, we can keep this new widget and make it compatible for Dash., TrueNAS, ...etc.
What would be your suggestion instead?
Since Hardware monitoring will be one of the main use cases of Homarr in general, I think we should add your new widget to the existing hardware monitoring category and then update that category to display additional information if available (e.g. by Bazel). That is more work, but better for the user, since they can choose any of the widgets and less confusing (why would the Bezel widget not be compatible with Dash. and the other way around? Why does the new widget not have "Bezel" in it's name if it's only strictly compatible with said app?)
There was a problem hiding this comment.
I agree that it and the others should be available in all 3 widgets if possible, however the structure of all 3 is quite different. Especially the heal monitoring which distinguishes between different drives etc.
This widget only has the percentage usage and additional infos that are not on the system health monitoring widget like network usage and the agent it is using. Also it shows the name of the system directly.
Do you think it makes more sense to not merge this today and discuss how we move forward further or that we release it today and if necessary change it (for example using a migration script) in an upcoming release?
I think the people would be quite happy with the addition and we can still improve it in upcoming releases
There was a problem hiding this comment.
Oh wait we are back in normal time, true 😂
Release was just now
|
Not PR related but I think the data sources that beszel displays could be sorted into the existing widget types (or new ones):
|
Homarr
Thank you for your contribution. Please ensure that your pull request meets the following pull request:
pnpm build, autofix withpnpm format:fix)devbranchx,y,ior any abbrevation)Closes #2645