Add CLI pipe support for filtering command output#29
Merged
rwestphal merged 1 commit intoholo-routing:mainfrom Mar 15, 2026
Merged
Add CLI pipe support for filtering command output#29rwestphal merged 1 commit intoholo-routing:mainfrom
rwestphal merged 1 commit intoholo-routing:mainfrom
Conversation
Add pipe infrastructure allowing users to filter command output through builtin and external pipe commands (e.g., `show route | include 192.168 | count`). Key changes: - New pipe module with PipeRegistry, PipeChain, and builtin filters (include, exclude, count, no-more) plus external command support (grep) - Refactored all command output to flow through session.writer() instead of direct println!/page_output, enabling pipe chain interception - Pipe-aware tab completion with argument hints - Typed error handling: CallbackError preserves io::ErrorKind::BrokenPipe through the callback chain; PipeError uses typed variants (Io, Spawn, ThreadPanicked, Filter) instead of String - XML command tree supports `pipe="true"` attribute for marking pipeable commands, with ancestor-walk inheritance via is_pipeable() - Quote-aware pipe splitting to support patterns with spaces
sha90w
force-pushed
the
feature/cli-pipes
branch
from
f852a12 to
78d33ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pipe infrastructure allowing users to filter command output through builtin and external pipe commands (e.g.,
show route | include 192.168 | count).Key changes:
pipe="true"attribute for marking pipeable commands, with ancestor-walk inheritance via is_pipeable()