Open
Conversation
Contributor
|
@sethvincent gui/ipc.js is part of preload, same as api.js... api.js is the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the following dialog methods to the ipc/api:
electron.dialog.showOpenDialog()electron.dialog.showSaveDialog()electron.dialog.showMessageBox()electron.dialog.showErrorBox()The main use case I have is showOpenDialog/showSaveDialog to avoid needing File System APIs and be able to easily do some localdrive->mirror-drive->hyperdrive stuff based on user input.
Otherwise it's File System API -> stream from ui to pear-end -> stream to somewhere -> ...
Unless there's another option I'm missing!
I skipped the sync methods and
showCertificateTrustDialogas they seem a lot less likely to be used but could add them.I didn't get super far because I got confused about the build process. Followed the
npm packinstructions but after install never saw the methods show up. I'm clearly doing something wrong 😅Anyway, I can make changes, add docs, etc. if this is something you're looking to add.