defer on_ack(UV_ECANCEL) if the packet is already in the send queue#281
Merged
jthomas43 merged 3 commits intoholepunchto:mainfrom Apr 2, 2026
Merged
defer on_ack(UV_ECANCEL) if the packet is already in the send queue#281jthomas43 merged 3 commits intoholepunchto:mainfrom
on_ack(UV_ECANCEL) if the packet is already in the send queue#281jthomas43 merged 3 commits intoholepunchto:mainfrom
Conversation
…o close stream if a destroy packet is already in the uv_udp_send queue. Add asserts to catch unexpected conditions
…d EFAULT, just log and drop the packet for others. also log partial packets, but process them.
kasperisager
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on_ack(CANCEL)on stream close if a packet is in the send queue, to prevent the user from freeing the underlying buffer before libuv sends the packet.close_streamif a destroy packet has already been scheduled to after the destroy is sent.