refactor udx_socket_send_ttl (needs fast-path-for-stream-write)#278
Open
jthomas43 wants to merge 1 commit intoholepunchto:mainfrom
Open
refactor udx_socket_send_ttl (needs fast-path-for-stream-write)#278jthomas43 wants to merge 1 commit intoholepunchto:mainfrom
jthomas43 wants to merge 1 commit intoholepunchto:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the udx_socket_send_ttl, when uv_udp_try_send() fails, instead of scheduling the packet with uv_udp_send() it sets a timer and tries again with uv_udp_try_send() again until it succeeds. This lets us remove the code that tracks where packets that need a specific TTL are in the uv_udp send queue, and the code that peeks the next packet to determine if adjusting the TTL is necessary.
This PR only makes sense if the fast-path for stream write (#277 ) is merged.