Skip to content

Fix: TLP from an existing packet calling uv_udp_send on packet twice. #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jthomas43 merged 1 commit into from
Feb 25, 2026
Merged

Fix: TLP from an existing packet calling uv_udp_send on packet twice. #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/udx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,14 +958,15 @@ udx_tlp_timeout (uv_timer_t *timer) {

// first try to send a new packet
if (!send_new_packet(stream, UDX_PROBE_TYPE_TLP)) {

udx_packet_t *pkt = (udx_packet_t *) udx__cirbuf_get(&stream->outgoing, stream->seq - 1);

if (!pkt || pkt->lost) {
if (!pkt || pkt->lost || pkt->ref_count == 2) {
schedule_loss_probe(stream);
return;
}

debug_printf("udx: sending tlp from existing packet");
debug_printf("udx: making tlp from existing packet %u\n", pkt->seq);

udx__queue_unlink(&stream->inflight_queue, &pkt->queue); // retransmit will add it back
retransmit_packet(stream, pkt);
Expand Down