Skip to content

Bump version and update dependencies in package.json#235

Open
zacharygriffee wants to merge 2 commits intoholepunchto:mainfrom
zacharygriffee:main
Open

Bump version and update dependencies in package.json#235
zacharygriffee wants to merge 2 commits intoholepunchto:mainfrom
zacharygriffee:main

Conversation

@zacharygriffee
Copy link
Copy Markdown

bogon isReserved exposed at 1.2.0 but hyperdht uses it and depends on 1.0.0.

bogon isReserved exposed at 1.2.0 but hyperdht uses it and depends on 1.0.0.
@RangerMauve
Copy link
Copy Markdown

Running into issues with this

@HDegroote
Copy link
Copy Markdown
Contributor

HDegroote commented Mar 25, 2026

Agreed that it should be min 1.2.0 to be cleaner, but don't immediately see how this could cause actual issues, since installing hyperdht afresh will just install bogon 1.2.0 due to the semantic versioning. Can you explain which issues you run into?

@RangerMauve
Copy link
Copy Markdown

Yup! I'm getting this error when I attempt to joinPeer in Hyperswarm.

  TypeError [Error]: isReserved is not a function
      at onlyNonReserved (/home/mauve/src/comapeo-core/node_modules/hyperdht/lib/connect.js:832:11)
      at Array.filter (<anonymous>)
      at holepunch (/home/mauve/src/comapeo-core/node_modules/hyperdht/lib/connect.js:235:48)
      at connectAndHolepunch (/home/mauve/src/comapeo-core/node_modules/hyperdht/lib/connect.js:193:9)

I could set up a minimal reproducible test if that'd help.

Currently hitting this as part of testing this code: https://github.com/digidem/comapeo-core/pull/1254/changes

@RangerMauve
Copy link
Copy Markdown

Maybe bogon was in my package lock already from another dependency?

@RangerMauve
Copy link
Copy Markdown

RangerMauve commented Mar 25, 2026

Yeah! Seems to be an issue with bogon already being a dependency in my project. Updating it there helped. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants