Bump version and update dependencies in package.json#235
Open
zacharygriffee wants to merge 2 commits intoholepunchto:mainfrom
Open
Bump version and update dependencies in package.json#235zacharygriffee wants to merge 2 commits intoholepunchto:mainfrom
zacharygriffee wants to merge 2 commits intoholepunchto:mainfrom
Conversation
bogon isReserved exposed at 1.2.0 but hyperdht uses it and depends on 1.0.0.
|
Running into issues with this |
Contributor
|
Agreed that it should be min 1.2.0 to be cleaner, but don't immediately see how this could cause actual issues, since installing hyperdht afresh will just install bogon 1.2.0 due to the semantic versioning. Can you explain which issues you run into? |
|
Yup! I'm getting this error when I attempt to I could set up a minimal reproducible test if that'd help. Currently hitting this as part of testing this code: https://github.com/digidem/comapeo-core/pull/1254/changes |
|
Maybe bogon was in my package lock already from another dependency? |
|
Yeah! Seems to be an issue with bogon already being a dependency in my project. Updating it there helped. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bogon isReserved exposed at 1.2.0 but hyperdht uses it and depends on 1.0.0.