Skip to content

Conversation

@cmdillon
Copy link

@cmdillon cmdillon commented Jun 20, 2025

Adds my profile to ‎profile-submission.json for the Product Designer role.

Closes #648

Summary by CodeRabbit

  • New Features
    • Added two new team profiles: "jediDean" (Jesse Dean) and "cmdillon" (Curtis Matthiesen-Dillon), each including their trial issue links.

✏️ Tip: You can customize this high-level summary in your review settings.

…l_name and github_trial_issue_link key-value pairs
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 20, 2025

Warning

Rate limit exceeded

@tiffmyaaw has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 31 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9f86383 and ec4f598.

📒 Files selected for processing (1)
  • profile-submission.json (2 hunks)

Walkthrough

Two new team profile objects were inserted into profile-submission.json's team_profiles array: jediDean (Jesse Dean) near the top and cmdillon (Curtis Matthiesen-Dillon) later in the array. No deletions or other modifications were made.

Changes

Cohort / File(s) Change Summary
Profile data
profile-submission.json
Inserted two new objects into the team_profiles array: one for jediDean (Jesse Dean) and one for cmdillon (Curtis Matthiesen-Dillon). No other edits.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check JSON validity and formatting.
  • Verify there are no duplicate profiles (e.g., jediDean appears in other PRs).
  • Confirm insert positions are intentional (ordering in the array).

Possibly related PRs

Suggested reviewers

  • markholdex

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions adding Curtis M-Dillon to profile-submission.json, which aligns with the main objective, but the raw summary indicates two profiles were added (jediDean and cmdillon), not just Curtis M-Dillon. Update the PR title to reflect that both jediDean and Curtis Matthiesen-Dillon profiles were added, or clarify the scope of changes in the title.
Out of Scope Changes check ⚠️ Warning The addition of jediDean (Jesse Dean) profile appears to be out-of-scope and unrelated to issue #648, which only requests Curtis Matthiesen-Dillon's profile to be added. Remove the jediDean profile addition if it is not part of issue #648, or link a separate issue that justifies including both profiles in this PR.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR addresses issue #648 by adding Curtis Matthiesen-Dillon's profile to profile-submission.json with the required applicant details (name, Telegram, LinkedIn, portfolio link, and application statement).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
profile-submission.json (1)

3-7: Inconsistent indentation for the jediDean entry
The indent levels here (8 spaces for { and 12 for keys) don’t match the rest of the file, which uses 4 spaces for objects and 6 for their properties. Please align this block to use 4-space indents for { and 6-space indents for the keys.

Apply this diff to normalize the indentation:

@@ lines 3-7
-        {
-            "github_handle": "jediDean",
-            "full_name": "Jesse Dean",
-            "github_trial_issue_link": "https://github.com/holdex/trial/issues/364"
-        },
+    {
+      "github_handle": "jediDean",
+      "full_name": "Jesse Dean",
+      "github_trial_issue_link": "https://github.com/holdex/trial/issues/364"
+    },
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ddbc24 and 331ebc4.

📒 Files selected for processing (1)
  • profile-submission.json (2 hunks)
🔇 Additional comments (1)
profile-submission.json (1)

237-241: New profile entry for cmdillon looks good
The object is appended with the correct keys, values, and comma placement. JSON structure is valid and consistent with existing entries.

@holdex
Copy link

holdex bot commented Jun 20, 2025

Time Submission Status

Member Status Time Action Last Update
cmdillon ✅ Submitted 1h 30min Update time Dec 16, 2025, 3:42 PM
tiffmyaaw ✅ Submitted 10min Update time Dec 16, 2025, 3:42 PM

Copy link
Contributor

@tiffmyaaw tiffmyaaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost. Please rename your PR title and description based on our Guidelines

PR description to link your issue manually should be the one in the same repo, not the other.

Follow this instruction to verify past commits

Last, don't forget to update your time spent on the PR Time Tracker bot.

Feel free to look at the successfully closed PRs in this repo for refs.

@cmdillon cmdillon changed the title Update profile to include correct information for: github_handle, ful… Added my profile to profile-submission.json Jun 20, 2025
@tiffmyaaw tiffmyaaw changed the title Added my profile to profile-submission.json chore(profile): added Curtis M-Dillon to profile-submission.json Dec 15, 2025
Signed-off-by: Tiffany V. Y.  <116727382+tiffmyaaw@users.noreply.github.com>
tiffmyaaw
tiffmyaaw previously approved these changes Dec 15, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 331ebc4 and 9f86383.

📒 Files selected for processing (1)
  • profile-submission.json (2 hunks)
🔇 Additional comments (2)
profile-submission.json (2)

443-447: cmdillon entry is correctly formatted and aligns with PR objective.

The addition of Curtis Matthiesen-Dillon's profile is accurate:

  • GitHub handle: cmdillon
  • Full name: Curtis Matthiesen-Dillon
  • Issue reference: #648
  • JSON structure and syntax are valid ✓

1-679: Critical: File contains multiple duplicate profile entries.

Scanning the file reveals several duplicate profiles that degrade data quality:

  • jediDean: appears at lines 4–7 and lines 104–107
  • lucky-ivanius: appears at lines 9–12 and lines 154–157
  • 0xcoreblock: appears at lines 224–227 and lines 654–657
  • roars2121: appears at lines 449–452 and lines 459–462
  • agung-setiawan: appears at lines 549–552 and lines 564–567

These duplicates should be removed. If this file is manually maintained, consider adding a merge-check or validation step to prevent future duplicates.

Should these duplicates be deduplicated as part of this PR, or in a separate issue?

Signed-off-by: Tiffany V. Y.  <116727382+tiffmyaaw@users.noreply.github.com>
Removed entry for Jesse Dean from profile submissions.

Signed-off-by: Tiffany V. Y.  <116727382+tiffmyaaw@users.noreply.github.com>
Signed-off-by: Tiffany V. Y.  <116727382+tiffmyaaw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add application to profile-submission.json

2 participants