-
Notifications
You must be signed in to change notification settings - Fork 225
chore(profile): added Curtis M-Dillon to profile-submission.json #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…l_name and github_trial_issue_link key-value pairs
|
Warning Rate limit exceeded@tiffmyaaw has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 31 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughTwo new team profile objects were inserted into Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
profile-submission.json (1)
3-7: Inconsistent indentation for thejediDeanentry
The indent levels here (8 spaces for{and 12 for keys) don’t match the rest of the file, which uses 4 spaces for objects and 6 for their properties. Please align this block to use 4-space indents for{and 6-space indents for the keys.Apply this diff to normalize the indentation:
@@ lines 3-7 - { - "github_handle": "jediDean", - "full_name": "Jesse Dean", - "github_trial_issue_link": "https://github.com/holdex/trial/issues/364" - }, + { + "github_handle": "jediDean", + "full_name": "Jesse Dean", + "github_trial_issue_link": "https://github.com/holdex/trial/issues/364" + },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
profile-submission.json(2 hunks)
🔇 Additional comments (1)
profile-submission.json (1)
237-241: New profile entry forcmdillonlooks good
The object is appended with the correct keys, values, and comma placement. JSON structure is valid and consistent with existing entries.
Time Submission Status
|
tiffmyaaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost. Please rename your PR title and description based on our Guidelines
PR description to link your issue manually should be the one in the same repo, not the other.
Follow this instruction to verify past commits
Last, don't forget to update your time spent on the PR Time Tracker bot.
Feel free to look at the successfully closed PRs in this repo for refs.
…l_name and github_trial_issue_link key-value pairs
Signed-off-by: Tiffany V. Y. <116727382+tiffmyaaw@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
profile-submission.json(2 hunks)
🔇 Additional comments (2)
profile-submission.json (2)
443-447: cmdillon entry is correctly formatted and aligns with PR objective.The addition of Curtis Matthiesen-Dillon's profile is accurate:
- GitHub handle:
cmdillon✓- Full name:
Curtis Matthiesen-Dillon✓- Issue reference:
#648✓- JSON structure and syntax are valid ✓
1-679: Critical: File contains multiple duplicate profile entries.Scanning the file reveals several duplicate profiles that degrade data quality:
jediDean: appears at lines 4–7 and lines 104–107lucky-ivanius: appears at lines 9–12 and lines 154–1570xcoreblock: appears at lines 224–227 and lines 654–657roars2121: appears at lines 449–452 and lines 459–462agung-setiawan: appears at lines 549–552 and lines 564–567These duplicates should be removed. If this file is manually maintained, consider adding a merge-check or validation step to prevent future duplicates.
Should these duplicates be deduplicated as part of this PR, or in a separate issue?
Signed-off-by: Tiffany V. Y. <116727382+tiffmyaaw@users.noreply.github.com>
Removed entry for Jesse Dean from profile submissions. Signed-off-by: Tiffany V. Y. <116727382+tiffmyaaw@users.noreply.github.com>
Signed-off-by: Tiffany V. Y. <116727382+tiffmyaaw@users.noreply.github.com>
Adds my profile to
profile-submission.jsonfor the Product Designer role.Closes #648
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.