-
Notifications
You must be signed in to change notification settings - Fork 18
fix: github leave request template format has errors #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Teodorus <53143942+teodorus-nathaniel@users.noreply.github.com>
WalkthroughA single placeholder field in the GitHub issue template for leave requests was updated from a numeric value to a string format to resolve an issue where the form appeared empty when accessed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bug Report Checklist
If this commit or author is incorrect, reply in this PR with:
Use git blame to identify the right commit and author before posting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/ISSUE_TEMPLATE/leave_request.yml (1)
13-78: Consider quoting all placeholder values for consistency.The template mixes quoted and unquoted placeholders. While YAML treats unquoted strings fine, the form-rendering issue reveals that GitHub's parser may be sensitive to type inference on numeric values. For defensive consistency and to prevent similar issues on future changes, quote all placeholder values:
- type: input id: full_name attributes: label: Full Name description: Your full name as in the agreement - placeholder: John Doe + placeholder: "John Doe" validations: required: true ... - type: textarea id: reason attributes: label: Reason (short & clear) description: No medical details required for sick leave - placeholder: Family wedding in Spain • Medical appointment • etc. + placeholder: "Family wedding in Spain • Medical appointment • etc." validations: required: true
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/ISSUE_TEMPLATE/leave_request.yml(1 hunks)
🔇 Additional comments (1)
.github/ISSUE_TEMPLATE/leave_request.yml (1)
45-45: Fix correctly addresses the empty form issue.Quoting the numeric placeholder value converts it from integer to string, aligning with GitHub's issue template parser expectations. This should resolve the empty template rendering issue reported in #680.
Time Submission Status
|
|
@pr-time-tracker bug commit f32b1fa && bug author @zolotokrylin |
resolves https://github.com/holdex/pr-time-tracker-webhooks/issues/680
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.