Skip to content

Conversation

@teodorus-nathaniel
Copy link
Contributor

@teodorus-nathaniel teodorus-nathaniel commented Dec 9, 2025

resolves https://github.com/holdex/pr-time-tracker-webhooks/issues/680

Summary by CodeRabbit

  • Chores
    • Updated the placeholder display for the Total Working Days Requested field in the leave request form.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Teodorus <53143942+teodorus-nathaniel@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

Walkthrough

A single placeholder field in the GitHub issue template for leave requests was updated from a numeric value to a string format to resolve an issue where the form appeared empty when accessed.

Changes

Cohort / File(s) Change Summary
GitHub Issue Template
.github/ISSUE_TEMPLATE/leave_request.yml
Updated placeholder for Total Working Days Requested field from numeric 7 to string "7"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-file, single-field configuration change with no logic alterations

Possibly related PRs

Suggested reviewers

  • markholdex

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: fixing format errors in the GitHub leave request template file.
Linked Issues check ✅ Passed The change addresses the linked issue #680 by fixing the leave_request.yml template format, which resolves the empty template problem.
Out of Scope Changes check ✅ Passed The changes are limited to the leave_request.yml file with a specific fix to the placeholder format, directly addressing the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@holdex
Copy link

holdex bot commented Dec 9, 2025

Bug Report Checklist

Status Commit Link Bug Author
✅ Submitted commit link @zolotokrylin

If this commit or author is incorrect, reply in this PR with:

@pr-time-tracker bug dispute <correct-commit-url> && bug author @correct-user

Use git blame to identify the right commit and author before posting.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/ISSUE_TEMPLATE/leave_request.yml (1)

13-78: Consider quoting all placeholder values for consistency.

The template mixes quoted and unquoted placeholders. While YAML treats unquoted strings fine, the form-rendering issue reveals that GitHub's parser may be sensitive to type inference on numeric values. For defensive consistency and to prevent similar issues on future changes, quote all placeholder values:

  - type: input
    id: full_name
    attributes:
      label: Full Name
      description: Your full name as in the agreement
-     placeholder: John Doe
+     placeholder: "John Doe"
    validations:
      required: true

  ...

  - type: textarea
    id: reason
    attributes:
      label: Reason (short & clear)
      description: No medical details required for sick leave
-     placeholder: Family wedding in Spain • Medical appointment • etc.
+     placeholder: "Family wedding in Spain • Medical appointment • etc."
    validations:
      required: true
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6faa396 and 1017288.

📒 Files selected for processing (1)
  • .github/ISSUE_TEMPLATE/leave_request.yml (1 hunks)
🔇 Additional comments (1)
.github/ISSUE_TEMPLATE/leave_request.yml (1)

45-45: Fix correctly addresses the empty form issue.

Quoting the numeric placeholder value converts it from integer to string, aligning with GitHub's issue template parser expectations. This should resolve the empty template rendering issue reported in #680.

@holdex
Copy link

holdex bot commented Dec 9, 2025

Time Submission Status

Member Status Time Action Last Update
teodorus-nathaniel ✅ Submitted 15min Update time Dec 9, 2025, 10:54 PM
zolotokrylin ✅ Submitted 5min Update time Dec 9, 2025, 10:56 PM

@teodorus-nathaniel
Copy link
Contributor Author

@pr-time-tracker bug commit f32b1fa && bug author @zolotokrylin

@zolotokrylin zolotokrylin merged commit 21ccbd3 into holdex:main Dec 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants