Skip to content

Conversation

@zolotokrylin
Copy link
Member

@zolotokrylin zolotokrylin commented Dec 8, 2025

Summary by CodeRabbit

Release Notes

  • Documentation
    • Updated advocacy guidelines with clearer, more prescriptive expectations for team member engagement on LinkedIn and X, including specific actionable items for social media presence.
    • Restructured profile management requirements into a standardized attribute table format for easier reference and consistency.
    • Improved formatting in leave policy documentation for enhanced readability.

✏️ Tip: You can customize this high-level summary in your review settings.

@zolotokrylin zolotokrylin self-assigned this Dec 8, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 8, 2025

Walkthrough

The changes rewrite advocacy guidelines documentation with more imperative language and introduce structured profile attribute requirements for GitHub, LinkedIn, and X/Twitter platforms. A minor formatting adjustment was made to the leave policy document.

Changes

Cohort / File(s) Change Summary
Documentation Overhaul
docs/ADVOCACY.md
Comprehensive rewrite shifting from normative to imperative stance; replaces narrative profile checklists with structured attribute-requirements table; updates social media guidance with specific actionable items for LinkedIn and X; tightens language throughout for policy-like clarity and consistency.
Formatting Adjustment
docs/LEAVE_POLICY.md
Line break repositioned in Reimbursable Leave item; no semantic or formula changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • docs/ADVOCACY.md: While substantial in scope, the changes are primarily documentation rewrites and structural transformations (narrative to table format) with no code logic to evaluate; focus review on consistency of messaging, accuracy of new attribute requirements, and clarity of policy intent.
  • docs/LEAVE_POLICY.md: Trivial formatting change requiring minimal scrutiny.

Possibly related PRs

Suggested reviewers

  • angelicawill
  • matthewvogas

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'refactor: advocate for Holdex' is vague and does not clearly convey the specific changes made in the pull request. Consider a more descriptive title such as 'refactor: update advocacy guidelines and policies' or 'refactor: restructure advocacy documentation' to better reflect the actual changes to ADVOCACY.md and LEAVE_POLICY.md.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ref/advocate-for-holdex

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zolotokrylin zolotokrylin marked this pull request as ready for review December 8, 2025 01:30
@holdex
Copy link

holdex bot commented Dec 8, 2025

Time Submission Status

Member Status Time Action Last Update
zolotokrylin ✅ Submitted 22min Update time Dec 8, 2025, 1:33 AM

@zolotokrylin zolotokrylin merged commit 2a8e112 into main Dec 8, 2025
3 of 4 checks passed
@zolotokrylin zolotokrylin deleted the ref/advocate-for-holdex branch December 8, 2025 01:32
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a373ce3 and b7e522a.

📒 Files selected for processing (2)
  • docs/ADVOCACY.md (1 hunks)
  • docs/LEAVE_POLICY.md (1 hunks)
🔇 Additional comments (4)
docs/LEAVE_POLICY.md (1)

48-49: Formatting change is clear and improves readability.

The line break adjustment maintains semantic meaning and aligns with standard Markdown formatting. No concerns.

docs/ADVOCACY.md (3)

1-9: Verify Code of Conduct reference and assess prescriptive tone.

The introduction establishes a mandatory advocacy framework with clear requirements. Line 9 references ./CODE_OF_CONDUCT.md—verify this file exists and is accessible. Additionally, the imperative language ("you must actively advocate") sets a high bar for employee expectations; consider whether this aligns with company culture and employee autonomy norms.


18-18: Unable to verify review comment—repository access failed.

The verification process could not be completed due to inability to access the repository. The review flags several requirements as "unconventional" (localhost location, exclusivity clause, hide time, empty email) and proposes specific diffs, but without access to the actual docs/ADVOCACY.md file, these claims cannot be confirmed or refuted.


42-50: Reconsider mandatory account tagging and prescriptive engagement language on X.

The X profile section contains language that may be overly prescriptive:

  1. Mandatory tagging of individuals — Requiring posts to tag [@zolotokrylin](https://x.com/zolotokrylin) may create forced engagement that appears inauthentic and could have unintended consequences for the tagged individual. If tagging is desired, make it contextual rather than mandatory.

  2. Prescriptive engagement language — "Engage actively: Share Holdex news/updates, interact with our community, respond to comments/questions" reads as mandatory surveillance of social media activity rather than guidance. Consider shifting to voluntary or outcome-oriented language (e.g., "When you engage on X, share relevant updates and interact authentically").

  3. "localhost" location — Clarify whether this is a placeholder or intentional; it's unclear for a social media profile guideline.

Consider revising to make tagging contextual and engagement voluntary:

- Engage actively: Share Holdex news/updates, interact with our community, respond
- to comments/questions, and tag [@holdexio](https://x.com/holdex.io) and
- [@zolotokrylin](https://x.com/zolotokrylin)
+ Engagement (optional): Share relevant Holdex updates and engage authentically with our community. When appropriate, mention [@holdexio](https://x.com/holdex.io).

Comment on lines +1 to +50
# Holdex Advocacy Guidelines

If you are a Holdex team member, we expect you to advocate for Holdex, its
mission, and its values. This includes:
As a Holdex team member, you must actively advocate for Holdex, its mission, and
its values. This requires:

- Participate in community events and activities that align with Holdex's
mission and values.
- Share Holdex-related content on social media platforms, including LinkedIn and
Twitter.
- Represent Holdex professionally and ethically, and to uphold the company's
code of conduct at all times.
- Participating in aligned community events and activities.
- Sharing and engaging with Holdex content on LinkedIn and X (formerly Twitter).
- Representing Holdex professionally, ethically, and in line with our
[Code of Conduct](./CODE_OF_CONDUCT.md).

## Social Media Presence

Your Personal Social Media Presence:
Maintain a professional online presence that promotes Holdex. Upon joining,
immediately update your GitHub, LinkedIn, and X profiles to reflect your role.

- Create and maintain a professional LinkedIn profile that showcases your work
at Holdex.
- Use Twitter to share Holdex-related news, updates, and insights.
- Engage with Holdex's community on social media platforms, responding to
comments and questions.
### GitHub Profile

When you join Holdex you must update your GitHub, LinkedIn and X (formally
Twitter) profiles to reflect Holdex.
Exclusively promote Holdex in your bio while employed—no other brands or links.
Checklist:

### Profile Checklist

### GitHub Bio

While employed by Holdex, exclusively promote Holdex in your bio. Do not include
other brands or non-Holdex links..

| Github Profile Attributes | Acceptance Criteria |
|---------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| Name | Only state your First Name |
| Bio | Describe your Role at Holdex. I.e.: “Full-stack Engineer at @holdex”> |
| Company | @holdex |
| Location | localhost |
| Time | Uncheck; don’t display current time |
| Email | Must be empty |
| Social link 1 – X | Must be: “<https://x.com/holdex.io”> |
| Social link 2 – Website | <https://holdex.io/c/jobs> |
| Social link 3 – LinkedIn | <https://linkedin.com/company/holdex> |
| Pinned Repositories | Trial |
| Overview | Create a ‘README.md’ file in public self-repo that states: role at Holdex, what you do & what you love about Holdex, link to Holdex website and GitHub organization profile. |
| Attribute | Requirement |
|-----------|-------------|
| Name | First name only. |
| Bio | Role at Holdex (e.g., "Full-stack Engineer at @holdex"). |
| Company | @holdex |
| Location | localhost |
| Time | Uncheck; hide current time. |
| Email | Empty. |
| Social Link: X | <https://x.com/holdex.io> |
| Social Link: website | <https://holdex.io/c/jobs> |
| Social Link: LinkedIn | <https://linkedin.com/company/holdex> |
| Pinned Repositories | Holdex-related only. |
| Overview | In a public self-repo, create README.md stating your role, contributions, enthusiasm for Holdex, and links to Holdex website and GitHub org. |

### LinkedIn Profile

Must mention Holdex in the ‘Experiences’ tab & place it as the recent / current
role.
Add Holdex as your current experience in the "Experience" section. Use this
mandatory description:

Mandatory `Experience` description:
> Holdex is premier partner for institutions pioneering DeFi & RWAs. Hong Kong-based since 2016, we turn bold visions into secure, scalable blockchain solutions – driving adoption with unmatched expertise.
> Holdex is the premier partner for institutions pioneering DeFi & RWAs. Hong Kong-based since 2016, we turn bold visions into secure, scalable blockchain solutions—driving adoption with unmatched expertise.
### X (Twitter) Profile

- Must mention your role @HoldexIo within the profile description.
- Link to Holdex website / portfolio.
- Location: localhost
- Description: State your role at @HoldexIo.
- Link: To Holdex website/portfolio.
- Location: localhost.

Engage actively: Share Holdex news/updates, interact with our community, respond
to comments/questions, and tag [@holdexio](https://x.com/holdex.io) and
[@zolotokrylin](https://x.com/zolotokrylin)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Assess overall prescriptiveness and employee autonomy impact.

While the rewrite successfully shifts the advocacy guidelines to a structured, policy-like format (aligning with the PR objective), the cumulative effect of multiple "mandatory" requirements—combined with restrictions (exclusivity clause), unusual specifications ("localhost"), and prescriptive engagement mandates—may create friction with employees and undermine authentic advocacy.

Recommendations:

  • Replace "must/mandatory" language with "should" in non-critical areas to preserve employee autonomy.
  • Allow flexibility for profile attributes that don't directly impact brand messaging (e.g., timezone/location, contact info).
  • Distinguish between hard requirements (e.g., Holdex company affiliation) and aspirational guidance (e.g., engagement on social media).
  • Consider adding a rationale section explaining why each requirement serves the company and employees.

This will maintain strong advocacy positioning while respecting employee agency.

Would you like me to generate a revised version that balances prescriptiveness with employee autonomy?

🤖 Prompt for AI Agents
In docs/ADVOCACY.md around lines 1–50 the advocacy guidelines are overly
prescriptive (many "must/mandatory" items, exclusivity clause, fixed
placeholders like "localhost") which reduces employee autonomy; revise by
replacing non-critical "must/mandatory" language with "should" or "recommended",
remove or rephrase the exclusivity requirement to allow personal affiliations,
replace hard-coded placeholders (e.g., "localhost") with flexible options like
"your city/region" or "optional", explicitly separate hard requirements (company
affiliation, acceptable conduct) from aspirational guidance (social engagement,
profile phrasing) using clear headings, and add a one-paragraph rationale under
each requirement explaining why it exists and whether it is optional or
required.

Comment on lines 35 to +40
### LinkedIn Profile

Must mention Holdex in the ‘Experiences’ tab & place it as the recent / current
role.
Add Holdex as your current experience in the "Experience" section. Use this
mandatory description:

Mandatory `Experience` description:
> Holdex is premier partner for institutions pioneering DeFi & RWAs. Hong Kong-based since 2016, we turn bold visions into secure, scalable blockchain solutions – driving adoption with unmatched expertise.
> Holdex is the premier partner for institutions pioneering DeFi & RWAs. Hong Kong-based since 2016, we turn bold visions into secure, scalable blockchain solutions—driving adoption with unmatched expertise.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Reconsider mandatory verbatim LinkedIn description.

Requiring employees to use identical, verbatim corporate copy in LinkedIn Experience descriptions may:

  1. Violate LinkedIn platform norms (which expect authentic, personal summaries).
  2. Appear inauthentic or spam-like when standardized across employees.
  3. Reduce individual voice and employee engagement with their own professional profiles.

Consider allowing employees to paraphrase the key message while maintaining brand consistency:

- Add Holdex as your current experience in the "Experience" section. Use this
- mandatory description:
-
- > Holdex is the premier partner for institutions pioneering DeFi & RWAs. Hong Kong-based since 2016, we turn bold visions into secure, scalable blockchain solutions—driving adoption with unmatched expertise.
+ Add Holdex as your current experience in the "Experience" section. Your description should highlight:
+ - Your role and contributions at Holdex
+ - Key focus area (e.g., DeFi, RWAs, blockchain solutions)
+ - Optional: Holdex's mission (e.g., "pioneering DeFi & RWAs solutions")
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
### LinkedIn Profile
Must mention Holdex in the ‘Experiences’ tab & place it as the recent / current
role.
Add Holdex as your current experience in the "Experience" section. Use this
mandatory description:
Mandatory `Experience` description:
> Holdex is premier partner for institutions pioneering DeFi & RWAs. Hong Kong-based since 2016, we turn bold visions into secure, scalable blockchain solutions – driving adoption with unmatched expertise.
> Holdex is the premier partner for institutions pioneering DeFi & RWAs. Hong Kong-based since 2016, we turn bold visions into secure, scalable blockchain solutions—driving adoption with unmatched expertise.
### LinkedIn Profile
Add Holdex as your current experience in the "Experience" section. Your description should highlight:
- Your role and contributions at Holdex
- Key focus area (e.g., DeFi, RWAs, blockchain solutions)
- Optional: Holdex's mission (e.g., "pioneering DeFi & RWAs solutions")
🤖 Prompt for AI Agents
In docs/ADVOCACY.md around lines 35-40, the current text mandates a verbatim
LinkedIn "Experience" description which risks inauthenticity and platform-policy
issues; change the wording to remove the requirement to paste exact copy and
instead require employees to list Holdex as their current employer and role
while allowing paraphrase; provide a short, optional "recommended blurb" that
employees may use or adapt, plus a small set of brand-approved keywords/phrases
to ensure consistency, and add a note linking to brand resources and legal/PR
contact for approvals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants