-
Notifications
You must be signed in to change notification settings - Fork 18
docs: view scope as optional #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughEditorial and formatting updates to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 2 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/CONTRIBUTING.md (1)
239-239: Clarify the optional scope notation to follow Conventional Commits convention.The current notation
type(scope [Optional]): actionis ambiguous—it's unclear whether the literal string[Optional]should appear in commit messages. The document references Conventional Commits (line 207), which uses square brackets around the optional element itself.Apply this diff to align with standard convention:
-1. Does it use `type(scope [Optional]): action` format? +1. Does it use `type([scope]): action` format?Then, optionally add clarifying text after the checklist item (e.g., "where scope is optional") if you'd like to be extra explicit.
Time Submission Status
|
|
Please review @zolotokrylin thank you! |
|
@angelicawill, could you please resolve this conflict? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/CONTRIBUTING.md(2 hunks)
🧰 Additional context used
🪛 GitHub Check: lint
docs/CONTRIBUTING.md
[warning] 283-283: MD029
Ordered list item number 4 does not match configured style 'one' (expected 1)
[warning] 282-282: MD029
Ordered list item number 3 does not match configured style 'one' (expected 1)
[warning] 281-281: MD029
Ordered list item number 2 does not match configured style 'one' (expected 1)
🔇 Additional comments (3)
docs/CONTRIBUTING.md (3)
280-280: ✅ Scope optionality clearly documented.The change explicitly notes
type(scope [Optional]): actionformat, directly addressing issue #66. This clarifies that scope is optional and should help reviewers avoid rejecting PRs solely for omitting scope.
285-291: New procedural guidance on time tracking is helpful.The "Requesting Review" section (lines 285–291) adds clear guidance about reporting time spent on PRs and contextualizes development work to include planning and QA phases. This reinforces accountability and realistic estimation.
239-276: Overall naming guidance improvements are clear and user-focused.The restructured PR naming requirements (user-focused, Conventional Commits, clear & simple), example comparison table, and emphasis on user capability over technical details strengthen the guidelines. The formatting and emphasis changes improve readability and hierarchy.
|
@zolotokrylin resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/CONTRIBUTING.md (1)
280-283: Clarify the optional scope notation for alignment with Conventional Commits standard.The change from
type(scope): actiontotype(scope [Optional]): actiondirectly addresses issue #66 by documenting that scope is optional. However, the Conventional Commits specification uses the notation<type>[optional scope]: <description>, which more clearly indicates optionality using square brackets.Consider revising to one of these alternatives for better alignment with the standard:
- Option 1 (Matches Conventional Commits standard): Change line 280 to:
type[(scope)]: actionand add clarifying text: "where(scope)is optional"- Option 2 (Keep current, add explanation): Retain the current format but immediately add: "where the scope in parentheses is optional"
This ensures contributors recognize the standard notation when they reference other Conventional Commits documentation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/CONTRIBUTING.md(2 hunks)
🔇 Additional comments (5)
docs/CONTRIBUTING.md (5)
239-241: Approve PR naming requirements section.Clear presentation of three core requirements for PR names. This section effectively communicates the standards to contributors.
245-249: Example comparison table is well-structured.The Good/Bad examples effectively illustrate the PR naming conventions. The "Why?" column provides helpful context for why certain formats are preferred.
257-267: Key Principles section strengthens user-focus messaging.The emphasis on "what users gain" over technical implementation is well-articulated. The use of ❌/✅ indicators provides visual clarity.
271-276: How to Apply It examples are practical and instructive.Concrete examples of wrong vs. correct approaches, with emphasis on user action verbs, make the guidance actionable for contributors.
287-291: Requesting Review section effectively communicates time-tracking expectations.The expanded guidance on reporting time across planning, implementation, and QA phases is clear and helpful. The note explaining that "Programming isn't just about writing code" provides good context for why full-stage time tracking is important.
resolves #66
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.