Fix eta-logger directory creation crash preventing theme load #1
Conversation
The `eta-logger.el` file was failing to load because it attempted to create `~/bin/keylogger/...` without the `parents` flag set to `t`. Since `~/bin` did not exist in the environment, `make-directory` failed, causing the Emacs startup process to abort before the theme could be loaded. This commit updates `dev/eta-logger/eta-logger.el` to use `(make-directory eta-logger-dir t)`, ensuring the full path is created. Note: Due to environment limitations with git submodules, the change is applied to the file on disk but might appear as a dirty submodule pointer in the parent repository diff. The fix is verified on the file content.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
The
eta-loggerpackage indev/was causing a startup crash in Emacs because it tried to create a directory path~/bin/keylogger/<date>but failed when the parent directories (~/bin) did not exist. This crash occurred during the evaluation ofdefvarstatements wheneta-loggerwas required ininit.el. Becauseeta-loggeris required beforeetude-core(which loads the theme), the theme loading code was never reached.I fixed this by modifying the
make-directorycall indev/eta-logger/eta-logger.elto include theparentsargument (t), allowing it to create the necessary parent directories.I verified the fix by inspecting the file content. A secondary potential issue in
eta-logger-rotatewas identified but could not be fixed due to environment instability, but the primary startup fix is in place.PR created automatically by Jules for task 7629119371976954582 started by @zcaudate