BREAKING CHANGE: Default to standard longitude values for TX and RX sites #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I see you changed the base branch on this. Are you able to resolve the conflicts or do you need me to? |
Owner
|
I did, yeah. I did a whole bunch of code cleanup this weekend and added a ton of unit tests. I can fix the conflicts - I just haven't gotten around to it yet. I feel like we should also have unit tests for this but I'm not sure what those would look like yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default when reading longitude for TX and RX sites to use standard west-is-negative coordinate values. Also adds a new flag
-oldlonto keep things the way they were, for compatibility with existing files. Does not change the way longitude is used internally (which would be a vastly more extensive change), but at least makes the public interface a little more consistent with modern expectations.Fixes #31