Fixed batch trigger scheduling during app type import #3
+228
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ected#225 - Prevent scheduling of 'once' frequency batch triggers during app type import - Added import_in_progress? check to handle_batch_schedule method - Only affects 'once' frequency triggers - other frequencies work normally - Fixed incomplete run_at parameter in else branch - Added comprehensive test coverage for import scenario - Test verifies no jobs created during import for 'once' frequency - Test verifies import_in_progress? flag management This resolves the issue where batch trigger dynamic models set to 'once' were being triggered unexpectedly when included in an app_type import.
…ected#225 - Added check to prevent 'once' frequency batch triggers from being scheduled during app type import - Fixed incomplete run_at parameter in handle_batch_schedule for recurring jobs - Added comprehensive test suite with proper delayed job configuration - Tests verify no jobs created during import and jobs are created normally after import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves consected#225
Summary
Fixed issue where dynamic models with
batch_trigger.frequency: oncewere being unexpectedly scheduled during app type imports. These one-time batch jobs should only be created when explicitly saved by an admin, not recreated on every configuration re-import.Changes
Dynamic::DefHandler#handle_batch_scheduleto skip scheduling 'once' frequency jobs whenAdmin::AppTypeImport.import_in_progress?is truerun_at:parameter in recurring job scheduling (was missing value)Tests