Minor performance improvement for LazyInjected #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a project where we are heavily using FactoryKit I noticed an issue in combination with Swift Concurrency.
One class that we are accessing through a factory has a slow
initand due to the usage of theglobalRecursiveLockit can easily block all cooperative queues when many instances are resolved in async contexts leading to thread contention. You can see this in the screenshots.Ultimately, we need to refactor our code and move the initialization out of the
init. But this PR is a very minor performance improvement with@LazyInjected. It always calls thereset(options:)function when initializing withoptions: .none. So at least here we can skip the lock. In the end it still needs the lock when resolving the dependency, but at least it's only locking once instead of twice then.