Convert ASCII to Binary without reading everything into memory#17
Open
kraigher wants to merge 1 commit intohmeyer:mainfrom
Open
Convert ASCII to Binary without reading everything into memory#17kraigher wants to merge 1 commit intohmeyer:mainfrom
kraigher wants to merge 1 commit intohmeyer:mainfrom
Conversation
- Adds try_stream_stl that takes iterator without triangle count - Adds convert_ascii_to_binary
Author
|
@hmeyer what do you think about this PR? Is it something you think belongs in the project? |
hmeyer
reviewed
Sep 16, 2024
| where | ||
| W: ::std::io::Write + std::io::Seek, | ||
| T: std::borrow::Borrow<Triangle>, | ||
| I: ::std::iter::Iterator<Item = Result<T>> |
Owner
There was a problem hiding this comment.
I think we could make this an ExactSizeIterator and avoid seeking back to the header, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try_stream_stlthat takes iterator without triangle countconvert_ascii_to_binary