Open
Conversation
hmcts-jenkins-j-to-z
bot
added
ns:sptribs
prd:sptribs
rel:sptribs-case-api-pr-2394
labels
james-matthews1
force-pushed
the
DTSSTCI-00
branch
from
9c92e1d to
60a5dba
Compare
james-matthews1
force-pushed
the
master
branch
from
65187d4 to
439fae5
Compare
pr00279
reviewed
Mar 26, 2026
| correspondences.add(correspondenceListValue); | ||
| } | ||
|
|
||
| blobCase.getCicCase().setApplicantDocuments(blobCase.getCicCase().getApplicantDocumentsUploaded()); |
Contributor
There was a problem hiding this comment.
To me this line is unnecessary, and it is even causing documents to appear twice in case file view - frontend should just read from ApplicantDocumentsUploaded rather than creating a whole new variable which just holds duplicate values
pr00279
reviewed
Mar 26, 2026
| label = "Applicant's full name", | ||
| access = {DefaultAccess.class, CaseworkerWithCAAAccess.class, CitizenAccess.class} | ||
| ) | ||
| private List<ListValue<CaseworkerCICDocument>> applicantDocuments; |
Contributor
There was a problem hiding this comment.
See comment in CicCaseView - this var is unnecessary when applicantDocumentsUploaded exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Enter a description.
JIRA link
https://tools.hmcts.net/jira/browse/DTSSTCI-
Before merging a pull request make sure that:
enable-e2e-testslabel can be used to run the e2e tests before QA handover and before release (required)If this ticket will have any visible impact on users and is not behind a feature toggle, make sure that:
Note that bug fixes, dependency updates and technical tasks do not directly impact the user experience and can be merged without QA and PO review.
If this user story cannot be immediately merged find a way to put it behind a feature toggle and get it merged.