DTSPB-5206 use json lib not strings#3728
Merged
tom-saunders-cts merged 12 commits intomasterfrom Apr 16, 2026
Merged
Conversation
CCD diff reportNo change |
hmcts-jenkins-j-to-z
Bot
added
ns:probate
prd:probate
rel:probate-back-office-pr-3728
labels
FeliTam
approved these changes
Apr 1, 2026
Contributor
Plan Result (aat) |
Contributor
Plan Result (prod) |
tom-saunders-cts
force-pushed
the
DTSPB-5206-use-json-lib-not-strings
branch
from
0d26917 to
f7cf29c
Compare
CCD diff reportNo change |
tom-saunders-cts
force-pushed
the
DTSPB-5206-use-json-lib-not-strings
branch
from
f7cf29c to
5231f74
Compare
CCD diff reportNo change |
this is probably not the best from a longer term perspective - and i'm not sure how this approach copes with potentially needing to remove values from the arrays.
Call new functinoality first then use old value.
it copies the behaviour from the single existing test for runQuery. i wonder whether there should be more coverage of this handling.
tom-saunders-cts
force-pushed
the
DTSPB-5206-use-json-lib-not-strings
branch
from
5231f74 to
fd6da55
Compare
CCD diff reportNo change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
See DTSPB-5206
Change description
Adds a new implementation (controlled by a feature toggle) which uses a JSON library based approach to constructing the JSON query for the case matching handling. This solves the issues we have seen where inputs have names have characters which cause the output generated by the existing handling to be malformed json and thus the queries to fail.
Does this PR introduce a breaking change? (check one with "x")