DTSPB-5217 added validation for checking dob and dod#3709
Open
DTSPB-5217 added validation for checking dob and dod#3709
Conversation
CCD diff reportNo change |
justiceia
commented
Mar 18, 2026
|
|
||
| ExceptionRecordCaseDataValidator.validateIhtValues(grantOfRepresentationData); | ||
|
|
||
| ExceptionRecordCaseDataValidator.validateDateOfDeath(grantOfRepresentationData); |
Contributor
Author
There was a problem hiding this comment.
moved because i added new line which made checkstylemain fail because modifiedFields was too far away from declaration and first usage
CCD diff reportNo change |
hmcts-jenkins-j-to-z
Bot
added
ns:probate
prd:probate
rel:probate-back-office-pr-3709
labels
CCD diff reportNo change |
CCD diff reportNo change |
1 similar comment
CCD diff reportNo change |
CCD diff reportNo change |
CCD diff reportNo change |
|
|
||
| public static void validateDateOfDeath(GrantOfRepresentationData caseData) { | ||
| List<String> errorMessages = new ArrayList<>(); | ||
| if (caseData.getDeceasedDateOfBirth() != null && caseData.getDeceasedDateOfDeath() != null) { |
Contributor
There was a problem hiding this comment.
so we only check if the date of death is in the future if we also have a date of birth?
| if (!caseData.getDeceasedDateOfDeath().isAfter(caseData.getDeceasedDateOfBirth())) { | ||
| errorMessages.add(DOD_BEFORE_DOB); | ||
| } | ||
| if (caseData.getDeceasedDateOfDeath().isAfter(LocalDate.now())) { |
Contributor
There was a problem hiding this comment.
generally prefer to use the LocalDate.now(Clock) implementation which allows for control of time in testing (we're sort of solving this the other way by making the test use a dynamic date of death)
CCD diff reportNo change |
CCD diff reportNo change |
CCD diff reportNo change |
CCD diff reportNo change |
CCD diff reportNo change |
tom-saunders-cts
approved these changes
Apr 13, 2026
CCD diff reportNo change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DTSPB-5217
Change description
added validation for dod and dob so when exception comes in it'll throw exception if fails validation
Does this PR introduce a breaking change? (check one with "x")