Open
Conversation
CCD diff reportCCD_Probate_Backoffice/CaseField/CaseField.json
|
CCD diff reportCCD_Probate_Backoffice/CaseField/CaseField.json
|
hmcts-jenkins-j-to-z
Bot
added
ns:probate
prd:probate
rel:probate-back-office-pr-3704
labels
…emplates in application.yml file
CCD diff reportCCD_Probate_Backoffice/CaseField/CaseField.json
|
CCD diff reportCCD_Probate_Backoffice/CaseField/CaseField.json
|
CCD diff reportCCD_Probate_Backoffice/CaseField/CaseField.json
|
CCD diff reportCCD_Probate_Backoffice/CaseField/CaseField.json
|
CCD diff reportCCD_Probate_Backoffice/CaseField/CaseField.json
|
Contributor
Plan Result (aat) |
Contributor
Plan Result (prod) |
CCD diff reportCCD_Probate_Backoffice/CaseField/CaseField.json
|
CCD diff reportCCD_Probate_Backoffice/CaseField/CaseField.json
|
CCD diff reportCCD_Probate_Backoffice/CaseField/CaseField.json
|
CCD diff reportCCD_Probate_Backoffice/CaseField/CaseField.json
|
FeliTam
approved these changes
Apr 21, 2026
| @@ -272,13 +272,21 @@ private void addCwDocumentToPersonalisation( | |||
| cwPrepareUpload(fileContents, personalisation, caseReference); | |||
| } catch (IOException e) { | |||
| log.error("Error reading CW document file : {}", e.getMessage()); | |||
Contributor
There was a problem hiding this comment.
maybe useful to log the actual exception here so we get a stack trace in the log as well as just the message
Comment on lines
+1602
to
+1628
| HashMap<String, String> personalisation = new HashMap<>(); | ||
|
|
||
| personalisation.put(PERSONALISATION_APPLICANT_NAME, | ||
| personalCaseDataCtscRequestInformation.getData().getPrimaryApplicantFullName()); | ||
| personalisation.put(PERSONALISATION_DECEASED_NAME, | ||
| personalCaseDataCtscRequestInformation.getData().getDeceasedFullName()); | ||
| personalisation | ||
| .put(PERSONALISATION_SOLICITOR_NAME, personalCaseDataCtscRequestInformation.getData().getSolsSOTName()); | ||
| personalisation | ||
| .put(PERSONALISATION_SOLICITOR_SOT_FORENAMES, null); | ||
| personalisation | ||
| .put(PERSONALISATION_SOLICITOR_SOT_SURNAME, null); | ||
| personalisation.put(PERSONALISATION_SOLICITOR_REFERENCE, | ||
| personalCaseDataCtscRequestInformation.getData().getSolsSolicitorAppReference()); | ||
| personalisation.put(PERSONALISATION_REGISTRY_NAME, "CTSC"); | ||
| personalisation.put(PERSONALISATION_REGISTRY_PHONE, "0300 303 0648"); | ||
| personalisation.put(PERSONALISATION_CASE_STOP_DETAILS_DEC, | ||
| personalCaseDataCtscRequestInformation.getData().getBoStopDetailsDeclarationParagraph()); | ||
| personalisation.put(PERSONALISATION_CASE_STOP_DETAILS, | ||
| personalCaseDataCtscRequestInformation.getData().getBoStopDetails()); | ||
| personalisation.put(PERSONALISATION_CAVEAT_CASE_ID, | ||
| personalCaseDataCtscRequestInformation.getData().getBoCaseStopCaveatId()); | ||
| personalisation.put(PERSONALISATION_DECEASED_DOD, | ||
| personalCaseDataCtscRequestInformation.getData().getDeceasedDateOfDeathFormatted()); | ||
| personalisation.put(PERSONALISATION_CCD_REFERENCE, personalCaseDataCtscRequestInformation.getId().toString()); | ||
| personalisation.put(PERSONALISATION_WELSH_DECEASED_DATE_OF_DEATH, localDateToWelshStringConverter | ||
| .convert(personalCaseDataCtscRequestInformation.getData().getDeceasedDateOfDeath())); |
Contributor
There was a problem hiding this comment.
this doesn't appear to be used anywhere (either as an input or to compare an output against)
Comment on lines
+2689
to
+2694
| .documentUploadIssue(YES) | ||
| .uploadFileCheck(YES) | ||
| .cwDocumentUpload(UploadDocument.builder() | ||
| .documentLink(documentLinkMock) | ||
| .documentType(SENT_EMAIL) | ||
| .build()); |
Contributor
There was a problem hiding this comment.
what does adding this cwDocumentUpload achieve here? we're never testing that the response has any of these values (or that it contains a collection of cw uploaded documents or similar)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DTSPB-4993
Change description
Does this PR introduce a breaking change? (check one with "x")