Open
Conversation
…28-250/edit-request-page
# Conflicts: # src/main/views/browse.njk
# Conflicts: # charts/pre-portal/values.stg.template.yaml # charts/pre-portal/values.yaml # config/default.json # local.env # src/main/modules/properties-volume/index.ts # src/main/routes/browse.ts # src/main/routes/watch-mk.ts # src/main/services/pre-api/pre-client.ts # src/main/views/watch-mk.njk # src/test/mock-api.ts
lucas-phillips28
changed the title
jasonpaige
requested changes
Dec 4, 2024
* Refactor Edit Request JS and UI * Lint Fix * Surpress known issues * Yarn audit * Remove Super User Sign Out * Change overlapping error message handling, placement and wording * Yarn lint and audit * Remove empty edit instruction guards * Lint --------- Co-authored-by: Lydia Ralph <lydia.ralph@justice.gov.uk>
…t-page # Conflicts: # src/main/services/pre-api/pre-client.ts
* Refactor Edit Request JS and UI * Lint Fix * Surpress known issues * Yarn audit * Remove Super User Sign Out * Change overlapping error message handling, placement and wording * Yarn lint and audit * Remove empty edit instruction guards * Add edit request unit tests * lint edit-request.ts * Replace placeholder GET edit-request with proper tests * Add jest-environment-jsdom * Add frontend JS tests --------- Co-authored-by: Lydia Ralph <lydia.ralph@justice.gov.uk>
* Add if statement to the recording version cell/column on /browse * Add if statement tests
* Update Runtime Reference to show the duration removed by the edit * Update Runtime Reference test to confirm it shows the duration removed by the edit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket(s)
Related PRs
Change description