fix: preserve original booking scheduledFor when processing COPY migr…#1388
Open
mazzopardi2 wants to merge 4 commits intomasterfrom
Open
fix: preserve original booking scheduledFor when processing COPY migr…#1388mazzopardi2 wants to merge 4 commits intomasterfrom
mazzopardi2 wants to merge 4 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When processing a COPY record through the resolve migrations pipeline, the booking's scheduledFor and the capture session's startedAt/finishedAt timestamps are incorrectly overwritten with the COPY's values. COPY records reuse the original record's booking and capture session, so these fields should be preserved - but instead they get replaced with different values from the COPY.
Fix:
For COPY records, the existing booking's scheduledFor and the existing capture session's startedAt, finishedAt, startedByUserId, and finishedByUserId are now fetched and preserved rather than being overwritten. For ORIG (non-COPY) records, behaviour is unchanged.
Test plan:
[ x ] Migrate an ORIG recording and verify scheduledFor and capture session timestamps are set correctly from the archive name
[ x ] Migrate a COPY record for the same booking via the resolve migrations pipeline and verify scheduledFor and capture session timestamps remain unchanged from the original