Skip to content

S28-4644 Remove traces of gc_state detection in recording processing #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GeorgeBarnesUK wants to merge 10 commits into
base: master
Choose a base branch
from
Open

S28-4644 Remove traces of gc_state detection in recording processing #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
33d7bc1
Basic gc_state fix without testing
GeorgeBarnesUK Dec 17, 2025
3a54e2a
Merge branch 'master' of https://github.com/hmcts/pre-api into S28-46…
GeorgeBarnesUK Jan 2, 2026
20b7924
Merge branch 'master' of https://github.com/hmcts/pre-api into S28-46…
GeorgeBarnesUK Jan 6, 2026
09576f9
Refactor some MK tests and add gc_state processing tests
GeorgeBarnesUK Jan 6, 2026
7d35be0
Cleanup mig file
GeorgeBarnesUK Jan 6, 2026
cbf012b
Remove gc_state detection method instead of deprecation
GeorgeBarnesUK Jan 6, 2026
fa28710
Remove test refs to gc_state
GeorgeBarnesUK Jan 7, 2026
e18b0e9
Merge branch 'master' into S28-4644/gc-state-cleanup
lydiaralphgov Feb 4, 2026
6896cac
Merge master
GeorgeBarnesUK Feb 9, 2026
a2c2850
Merge branch 'master' into S28-4644/gc-state-cleanup
lydiaralphgov Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/main/java/uk/gov/hmcts/reform/preapi/media/MediaKind.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,10 +363,9 @@ private void startLiveEvent(String liveEventName) {
@Override
public String triggerProcessingStep1(CaptureSessionDTO captureSession, String captureSessionNoHyphen,
UUID recordingId) {
if (!azureIngestStorageService.doesValidAssetExist(captureSession.getBookingId().toString())) {
log.info("No valid asset files found for capture session [{}] in container named [{}]",
captureSession.getId(),
captureSession.getBookingId().toString()
if (!checkLiveFeedAvailable(captureSession.getId())) {
log.info("No valid recording content found for capture session [{}] in Mediakind",
captureSession.getId()
);
azureIngestStorageService.markContainerAsSafeToDelete(captureSession.getBookingId().toString());
return null;
Expand Down
5 changes: 0 additions & 5 deletions src/main/java/uk/gov/hmcts/reform/preapi/media/storage/AzureIngestStorageService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

@Service
public class AzureIngestStorageService extends AzureStorageService {
private static final String BLOB_GC_STATE = "gc_state";
private static final String TAG_KEY_STATUS = "status";
private static final String TAG_VALUE_PROCESSING = "processing";
private static final String TAG_VALUE_SAFE_TO_DELETE = "safe_to_delete";
Expand All @@ -17,10 +16,6 @@ public AzureIngestStorageService(BlobServiceClient ingestStorageClient, AzureCon
super(ingestStorageClient, azureConfiguration);
}

public boolean doesValidAssetExist(String containerName) {
return doesIsmFileExist(containerName) || doesBlobExist(containerName, BLOB_GC_STATE);
}

public void markContainerAsProcessing(String containerName) {
tagAllBlobsInContainer(containerName, TAG_KEY_STATUS, TAG_VALUE_PROCESSING);
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/uk/gov/hmcts/reform/preapi/controller/MediaServiceControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@ void checkStreamCaptureSessionIsmFileExists() throws Exception {

@Test
@DisplayName("Should return 200 with updated capture session when streaming path exists")
void checkStreamCaptureSessionGcStateExists() throws Exception {
void checkStreamCaptureSessionStreamingPathExists() throws Exception {
var dto = new CaptureSessionDTO();
dto.setId(UUID.randomUUID());
dto.setStatus(RecordingStatus.STANDBY);
Expand Down
Loading
Loading