HDPI 3789 tenancy notice welsh postcodes FE#994
Open
sdmiddletonSolirius wants to merge 13 commits intomasterfrom
Open
HDPI 3789 tenancy notice welsh postcodes FE#994sdmiddletonSolirius wants to merge 13 commits intomasterfrom
sdmiddletonSolirius wants to merge 13 commits intomasterfrom
Conversation
sdmiddletonSolirius
added
enable_keep_helm
pcs-api-pr:1611
and removed
pcs-api-pr:1593
labels
sdmiddletonSolirius
requested review from
AlexBuzea,
libanAbdirahman1,
linusnorton,
paddy-hmcts and
scottstewart-sl
| const otherTenancyTypeDetails = req.res?.locals.validatedCase?.data | ||
| ?.tenancy_DetailsOfOtherTypeOfTenancyLicence as string; | ||
| const caseData = req.res?.locals.validatedCase?.data; | ||
| const welsh = await isWelshProperty(req); |
Contributor
There was a problem hiding this comment.
Minor - to avoid confusion we generally use the term "Wales" for the property location and "Welsh" for the language, so perhaps rename this method accordingly. Also it would be slightly better to name the local variable as walesProperty or isWalesProperty.
It would also be nice if there was a way to have an overloaded function where you can pass in the caseData - is anything like that possible in NodeJS?
Finally, does the isWelshProperty function actually have to be async?
| translationKey: { | ||
| label: 'correctTypeLabel', | ||
| }, | ||
| validator: (value: unknown): boolean | string => { |
Contributor
There was a problem hiding this comment.
This function return type seems a bit odd to me, but I see you are just fitting in with the existing implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See HDPI-3789
Change description
tenancyTypeWalesStandard/tenancyTypeWalesSecure); England behaviour unchanged.Testing done
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist