Skip to content

Notify team members via webhook#987

Open
toby-plunkett wants to merge 6 commits intomasterfrom
Create-send-team-members.yml
Open

Notify team members via webhook#987
toby-plunkett wants to merge 6 commits intomasterfrom
Create-send-team-members.yml

Conversation

@toby-plunkett
Copy link
Copy Markdown
Collaborator

Same implementation as seen on pcs-api

jobs:
send_reviewers:
runs-on: ubuntu-latest
if: github.event.pull_request.draft == false
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was previously mentioned, but could you perhaps check the status of the build beforehand?

PR_AUTHOR: ${{ github.event.pull_request.user.login }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
echo "Waiting for reviewer assignment..."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering as the code below is quite lengthy, perhaps could split up into a separate script that can be called here

Copy link
Copy Markdown
Contributor

@paddy-hmcts paddy-hmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left a few comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants