Skip to content

radio button fix#1010

Open
srinijg wants to merge 19 commits intomasterfrom
HDPI-5517-SafariFix
Open

radio button fix#1010
srinijg wants to merge 19 commits intomasterfrom
HDPI-5517-SafariFix

Conversation

@srinijg
Copy link
Copy Markdown

@srinijg srinijg commented Mar 30, 2026 •
edited
Loading

Jira link

https://tools.hmcts.net/jira/browse/HDPI-5517

Change description

This automation addresses the Radio button and other timeout issues encountered in Safari

Testing done

Screenshot 2026-03-31 at 20 17 52 Screenshot 2026-03-31 at 20 17 41

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@srinijg srinijg requested review from a team as code owners March 30, 2026 14:54
@srinijg srinijg added enable_full_functional_tests enable_all_page_functional_tests Enables page functional tests for all e2e pages. labels Mar 30, 2026
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview March 30, 2026 16:29 Abandoned
SameenaHMCTS
SameenaHMCTS reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@SameenaHMCTS SameenaHMCTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package.json chnages will be reverted right?

@srinijg
Copy link
Copy Markdown
Author

srinijg commented Mar 31, 2026

Yes @SameenaHMCTS package.json changes will be reverted before the final merge

SameenaHMCTS
SameenaHMCTS approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@SameenaHMCTS SameenaHMCTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

scottstewart-sl
scottstewart-sl reviewed Mar 31, 2026
View reviewed changes
lovelin-07
lovelin-07 approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@lovelin-07 lovelin-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Gautham059
Gautham059 approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Gautham059 Gautham059 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Conditionally approved it.
As agreed, If the change doesn't fix issues with safari, all the timeout changes from page naviagtion file must be reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottstewart-sl scottstewart-sl scottstewart-sl left review comments

@SameenaHMCTS SameenaHMCTS SameenaHMCTS approved these changes

@Gautham059 Gautham059 Gautham059 approved these changes

@lovelin-07 lovelin-07 lovelin-07 approved these changes

@tvr-hmcts tvr-hmcts tvr-hmcts approved these changes

@adusumillipraveen adusumillipraveen Awaiting requested review from adusumillipraveen adusumillipraveen is a code owner automatically assigned from hmcts/possession-claim-service-admins

Assignees

No one assigned

Labels

enable_all_page_functional_tests Enables page functional tests for all e2e pages. enable_full_functional_tests ns:pcs prd:pcs rel:pcs-frontend-pr-1010

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@srinijg @scottstewart-sl @SameenaHMCTS @Gautham059 @lovelin-07 @tvr-hmcts