HDPI-3344: set invalid fee register url for negative testing#1620
Open
HDPI-3344: set invalid fee register url for negative testing#1620
Conversation
benouaer
requested review from
a team,
AmandaRichards,
ayub-macalim,
linusnorton and
saurabhvalsangkar-hmcts
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/23909431296?check_suite_focus=true No change |
tvr-hmcts
reviewed
Apr 2, 2026
| java: | ||
| environment: | ||
| FEES_REGISTER_API_URL: "https://wiremock-${SERVICE_NAME}.preview.platform.hmcts.net" | ||
| FEES_REGISTER_API_URL: "https://invalid-fee-register-url.preview.platform.hmcts.net" |
Contributor
There was a problem hiding this comment.
Wondering if there is another approach that could be take to this. Still using the configured SERVICE_NAME but applying different wiremock stubs to return the relevant HTTP codes to mimic the behaviour required?
Author
There was a problem hiding this comment.
this was done as a quick and dirty change to enable manual negative testing
if we want to create an automated test for this, we should definitely configure the appropriate wiremock response
plus, the thing we're trying to mimic here is the service being down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
Change description
Testing done
--
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist