PO-1917

src/app/constants/fines-permissions.constant.ts

@@ -11,6 +11,7 @@ export const FINES_PERMISSIONS: IFinesPermissions = {
   'add-account-activity-notes': 8,
   'amend-payment-terms': 9,
   'enter-enforcement': 10,
+  'add-remove-payment-hold': 12,
   consolidate: 13,
   'operational-report-by-enforcement': 14,
   'operational-report-by-payments': 15,

src/app/flows/fines/fines-acc/fines-acc-defendant-details/fines-acc-defendant-details.component.html

@@ -1,7 +1,7 @@
 <app-fines-acc-summary-header
   [accountStore]="accountStore"
   id="defendant"
-  [hasAddAccountActivityNotePermission]="hasPermission('add-account-activity-notes')"
+  [hasAddAccountActivityNotePermission]="hasPermission(finesPermissions['add-account-activity-notes'])"
   (refreshPage)="refreshPage()"
   (navigateToAddAccountNotePage)="navigateToAddAccountNotePage()"
 ></app-fines-acc-summary-header>
@@ -149,7 +149,7 @@ <h2 opal-lib-custom-account-information-item-label>Business Unit:</h2>
     @if (tabAtAGlance$ | async; as tabData) {
       <app-fines-acc-defendant-details-at-a-glance-tab
         [tabData]="tabData"
-        [hasAccountMaintenencePermission]="hasPermission('account-maintenance')"
+        [hasAccountMaintenencePermission]="hasPermission(finesPermissions['account-maintenance'])"
         (addComments)="navigateToAddCommentsPage()"
         [style]="tabContentStyles"
       ></app-fines-acc-defendant-details-at-a-glance-tab>
@@ -159,8 +159,7 @@ <h2 opal-lib-custom-account-information-item-label>Business Unit:</h2>
     @if (tabDefendant$ | async; as tabData) {
       <app-fines-acc-defendant-details-defendant-tab
         [tabData]="tabData"
-        [hasAccountMaintenencePermission]="hasPermission('account-maintenance')"
-        [canAddParentOrGuardianDetails]="canAddParentOrGuardianDetails"
+        [hasAccountMaintenencePermission]="hasPermission(finesPermissions['account-maintenance'])"
         (addComments)="navigateToAddCommentsPage()"
         [style]="tabContentStyles"
         (changeDefendantDetails)="navigateToAmendPartyDetailsPage($event)"
@@ -173,7 +172,7 @@ <h2 opal-lib-custom-account-information-item-label>Business Unit:</h2>
     @if (tabParentOrGuardian$ | async; as tabData) {
       <app-fines-acc-defendant-details-parent-or-guardian-tab
         [tabData]="tabData"
-        [hasAccountMaintenencePermission]="hasPermission('account-maintenance')"
+        [hasAccountMaintenencePermission]="hasPermission(finesPermissions['account-maintenance'])"
         (addComments)="navigateToAddCommentsPage()"
         [style]="tabContentStyles"
         (changeParentOrGuardianDetails)="navigateToAmendPartyDetailsPage($event)"
@@ -193,7 +192,7 @@ <h2 opal-lib-custom-account-information-item-label>Business Unit:</h2>
     @if (tabPaymentTerms$ | async; as tabData) {
       <app-fines-acc-defendant-details-payment-terms-tab
         [tabData]="tabData"
-        [hasAmendPaymentTermsPermission]="hasPermission('amend-payment-terms')"
+        [hasAmendPaymentTermsPermission]="hasPermission(finesPermissions['amend-payment-terms'])"
         [style]="tabContentStyles"
         (changePaymentTerms)="navigateToAmendPaymentTermsPage()"
         (requestPaymentCard)="navigateToRequestPaymentCardPage()"
@@ -205,8 +204,8 @@ <h2 opal-lib-custom-account-information-item-label>Business Unit:</h2>
       <app-fines-acc-defendant-details-enforcement-tab
         [tabData]="tabData"
         [isCompanyAccount]="accountData.party_details.organisation_flag"
-        [hasAccountMaintenancePermission]="hasPermission('account-maintenance')"
-        [hasEnterEnforcementPermission]="hasPermission('enter-enforcement')"
+        [hasAccountMaintenancePermission]="hasPermission(finesPermissions['account-maintenance'])"
+        [hasEnterEnforcementPermission]="hasPermission(finesPermissions['enter-enforcement'])"
         (addEnforcementOverride)="navigateToAddEnforcementOverridePage()"
         (changeEnforcementOverride)="navigateToChangeEnforcementOverridePage()"
         (removeEnforcementOverride)="navigateToRemoveEnforcementOverridePage()"

src/app/flows/fines/fines-acc/fines-acc-defendant-details/fines-acc-defendant-details.component.spec.ts

@@ -54,10 +54,12 @@ describe('FinesAccDefendantDetailsComponent', () => {
     };
 
     mockPayloadService = {
-      transformAccountHeaderForStore: vi.fn().mockName('FinesAccPayloadService.transformAccountHeaderForStore'),
+      transformDefendantAccountHeaderForStore: vi
+        .fn()
+        .mockName('FinesAccPayloadService.transformDefendantAccountHeaderForStore'),
       transformPayload: vi.fn().mockName('FinesAccPayloadService.transformPayload'),
     };
-    mockPayloadService.transformAccountHeaderForStore.mockReturnValue(MOCK_FINES_ACCOUNT_STATE);
+    mockPayloadService.transformDefendantAccountHeaderForStore.mockReturnValue(MOCK_FINES_ACCOUNT_STATE);
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     mockPayloadService.transformPayload.mockImplementation((...args: any[]) => {
       return args[0]; // returns the first argument = payload