Po 2255 operation report by enforcement service data generation#1603
Closed
marcmollins wants to merge 12 commits intomasterfrom
Closed
Po 2255 operation report by enforcement service data generation#1603marcmollins wants to merge 12 commits intomasterfrom
marcmollins wants to merge 12 commits intomasterfrom
Conversation
marcmollins
force-pushed
the
PO-2255-OperationReportByEnforcementService-data-generation
branch
from
09c5b51 to
32f066f
Compare
sarahtw-cgi
reviewed
Mar 18, 2026
| private String empTel; // debtor_detail.employer_telephone | ||
| private String empEmail; // debtor_detail.employer_email | ||
| private String lastEnf; // defendant_accounts.last_enforcement (code) | ||
| private LocalDate edrDate; |
Contributor
There was a problem hiding this comment.
what does edrDate stand for?
sarahtw-cgi
reviewed
Mar 18, 2026
sarahtw-cgi
reviewed
Mar 18, 2026
sarahtw-cgi
reviewed
Mar 18, 2026
sarahtw-cgi
reviewed
Mar 19, 2026
sarahtw-cgi
reviewed
Mar 19, 2026
sarahtw-cgi
reviewed
Mar 19, 2026
sarahtw-cgi
reviewed
Mar 19, 2026
| } | ||
| String s = status.trim().toLowerCase(); | ||
| if ("live".equals(s)) { | ||
| return cb.and(cb.greaterThan(root.get("accountBalance"), cb.literal(0)), |
Contributor
There was a problem hiding this comment.
A lot of these string are being repeated. Could they be made into constants?
sarahtw-cgi
reviewed
Mar 19, 2026
sarahtw-cgi
reviewed
Mar 19, 2026
sarahtw-cgi
reviewed
Mar 19, 2026
sarahtw-cgi
reviewed
Mar 19, 2026
sarahtw-cgi
reviewed
Mar 19, 2026
| assertThat(report.getTransactionList()).isEmpty(); | ||
|
|
||
| ReportMetaData meta = report.getReportMetaData(); | ||
| if (meta == null) { |
Contributor
There was a problem hiding this comment.
this null check seems unnecessary
sarahtw-cgi
reviewed
Mar 19, 2026
sarahtw-cgi
reviewed
Mar 19, 2026
sarahtw-cgi
requested changes
Mar 19, 2026
sarahtw-cgi
reviewed
Mar 19, 2026
marcmollins
force-pushed
the
PO-2255-OperationReportByEnforcementService-data-generation
branch
from
d233615 to
9fede2c
Compare
sarahtw-cgi
force-pushed
the
PO-2255-OperationReportByEnforcementService-data-generation
branch
from
9fede2c to
84c506f
Compare
initial commit - reports
made small changes
fixing checkstyle
sarahtw-cgi
force-pushed
the
PO-2255-OperationReportByEnforcementService-data-generation
branch
from
a5db11e to
9f7aff1
Compare
Contributor
|
Closed to create a new clean pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PO-2255
Change description
Does this PR introduce a breaking change? (check one with "x")