[NFDIV-5200] No Respondent Address / Pre-issue service applications (Base Branch)#4485
Draft
adamg-hmcts wants to merge 39 commits intomasterfrom
Draft
[NFDIV-5200] No Respondent Address / Pre-issue service applications (Base Branch)#4485adamg-hmcts wants to merge 39 commits intomasterfrom
adamg-hmcts wants to merge 39 commits intomasterfrom
Conversation
* Add initial journey pages and configuration * Improve variable naming * Refactor file upload variables * Remove more merge conflicts * Set update details link based on whether the case has been issued * Update unit tests * Update E2E tests * Update backend PR link * Tweak route hiding tests * Linter corrections * Update src/main/steps/applicant1/interim-applications/no-respondent-address/will-apply-to-send-papers/content.ts Co-authored-by: FaisalMoJ <100577377+FaisalMoJ@users.noreply.github.com> * Update src/main/steps/applicant1/interim-applications/no-respondent-address/will-apply-to-send-papers/content.ts Co-authored-by: FaisalMoJ <100577377+FaisalMoJ@users.noreply.github.com> --------- Co-authored-by: FaisalMoJ <100577377+FaisalMoJ@users.noreply.github.com>
…div-5200-pre-issue-service-applications
Contributor
Plan Result (aat)
Change Result (Click me) # module.nfdiv-frontend-redis6.azurerm_redis_cache.redis will be updated in-place
~ resource "azurerm_redis_cache" "redis" {
id = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/nfdiv-cache-aat/providers/Microsoft.Cache/redis/nfdiv-frontend-aat"
name = "nfdiv-frontend-aat"
tags = {
"application" = "no-fault-divorce"
"autoShutdown" = "true"
"builtFrom" = "https://github.com/HMCTS/nfdiv-frontend.git"
"businessArea" = "CFT"
"contactSlackChannel" = "#no-fault-divorce"
"environment" = "staging"
"managedBy" = "No Fault Divorce"
}
# (24 unchanged attributes hidden)
~ redis_configuration {
~ maxfragmentationmemory_reserved = 125 -> 642
~ maxmemory_delta = 125 -> 642
~ maxmemory_reserved = 125 -> 642
# (14 unchanged attributes hidden)
}
}
Plan: 0 to add, 1 to change, 0 to destroy. |
Contributor
Plan Result (prod) |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
…se with service (#4507) * NFDIV-4992 Update NextStep for NO_RESP_ADDRESS_SEARCHING_FOR_DETAILS * NFDIV-4992 Add unit test * NFDIV-4992 Update content and translations * Update yarn-audit-known-issues * Update yarn-audit-known-issues * NFDIV-4992 Move steps to common, add reimplementation to journeys, update tests * NFDIV-4992 Fix linting error * Update yarn-audit-known-issues * Update yarn-audit-known-issues * NFDIV-4992 Revert unintentional commit to FT
* NFDIV-4992 Update NextStep for NO_RESP_ADDRESS_SEARCHING_FOR_DETAILS * NFDIV-4992 Add unit test * NFDIV-4992 Update content and translations * Update yarn-audit-known-issues * Update yarn-audit-known-issues * Make search gov records available pre-issue * Add pre-issue search gov end to end * NFDIV-4992 Move steps to common, add reimplementation to journeys, update tests * NFDIV-4992 Fix linting error * Update yarn-audit-known-issues * Update yarn-audit-known-issues * NFDIV-4992 Revert unintentional commit to FT * Make search gov link available pre-issue * NFDIV-5146 Pre issue dispense service app (#4561) * NFDIV-5146 - Dispense with service changes * NFDIV-5146 - Rework document upload for dispense journey --------- Co-authored-by: BWeeks-JusticeGovUK <92433491+BWeeks-JusticeGovUK@users.noreply.github.com> Co-authored-by: pallavijustice <pallavi.saha@justice.gov.uk> Co-authored-by: pallavijustice <159147694+pallavijustice@users.noreply.github.com>
* NFDIV-4922: Applicant2 address question pages * NFDIV-4922: Fix url issue * NFDIV-4922: move address question after solicitor details * NFDIV-4922: Fix yarn audit issue * NFDIV-4922: Fix logic around addres * NFDIV-4922: Fix logic around address * NFDIV-4922: Fix conditional for solicitor page * Update src/main/steps/applicant1/address-finding/content.ts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * NFDIV-4922: Fix PR comments * NFDIV-4922: Update form nunjuck file * NFDIV-4922: Adjust address finding logic * NFDIV-4922: Revert changes for further action needed * NFDIV-4922: Revert further action needed nunjuck changes * NFDIV-4922: Remove unwanted changes * NFDIV-4922: Set applicant1 knows address if found address * Apply suggestion from @adamg-hmcts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * NFDIV-4922: Refactor code to remove represented content and use ternary * Apply suggestion from @adamg-hmcts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * NFDIV-4922: Remove dependency update changes * NFDIV-4922: Refactor do you have address page content * NFDIV-4922: Re order steps in sequence file * NFDIV-4922: Fix generic error and label * NFDIV-4922: Add postal in the label * NFDIV-4949: Add page for international address (#4459) * NFDIV-4949: Add page for international address * NFDIV-4949: Fix unit tests * Apply suggestion from @adamg-hmcts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * Update src/main/steps/applicant1/address-international/content.ts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * Update src/main/steps/applicant1/address-international/template.njk Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * NFDIV-4949: Reorder sequence file * NFDIV-4949: Remove duplicate entries for steps * NFDIV-4949: Remove duplicate entries for steps * NFDIV-4949: Update content on email address page * NFDIV-4949: Fix lint issue * Clean up typos * NFDIV-4949: Add international address guidance * NFDIV-4949: Revert previous commit about international guidance * NFDIV-4949: Update button label to the new design * NFDIV-4949: Revert use this address as agreed to continue label for button --------- Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> Co-authored-by: elis.davies <elis.davies@justice.gov.uk> * NFDIV-4922: Fix issues with cya page * NFDIV-4922: Fix functional test * NFDIV-4922: Connect to backend PR * NFDIV-4922: Fix functional test --------- Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> Co-authored-by: elis.davies <elis.davies@justice.gov.uk>
* NFDIV-4922: Applicant2 address question pages * NFDIV-4922: Fix url issue * NFDIV-4922: move address question after solicitor details * NFDIV-4922: Fix yarn audit issue * NFDIV-4922: Fix logic around addres * NFDIV-4922: Fix logic around address * NFDIV-4949: Add page for international address * NFDIV-4922: Fix conditional for solicitor page * NFDIV-4949: Fix unit tests * Update src/main/steps/applicant1/address-finding/content.ts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * NFDIV-4922: Fix PR comments * Apply suggestion from @adamg-hmcts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * NFDIV-4922: Update form nunjuck file * NFDIV-4922: Adjust address finding logic * NFDIV-4949: Remove pages that are no longer needed and related code * NFDIV-4949: Fix unit tests * NFDIV-4922: Revert changes for further action needed * Merge branch parent * NFDIV-5164: Add further action needed submitted page * NFDIV-4922: Revert further action needed nunjuck changes * NFDIV-5164: Add further action needed nunjuck changes * NFDIV-4922: Remove unwanted changes * NFDIV-5164: Revert removal of serve another way checkbox * NFDIV-5164: Add serve another way back * NFDIV-4922: Set applicant1 knows address if found address * Apply suggestion from @adamg-hmcts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * NFDIV-5164: Fix content logic * NFDIV-5164: Update hub page * NFDIV-5164: Update application submitted and hub page * NFDIV-4922: Refactor code to remove represented content and use ternary * Apply suggestion from @adamg-hmcts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * NFDIV-4922: Remove dependency update changes * NFDIV-4922: Refactor do you have address page content * NFDIV-5164: Fix issues with content * NFDIV-5164: Adjust heading size * NFDIV-4922: Re order steps in sequence file * Update src/main/steps/applicant1/address-international/content.ts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * Update src/main/steps/applicant1/address-international/template.njk Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * NFDIV-4949: Reorder sequence file * Update src/main/steps/applicant1/application-submitted/template.njk Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * NFDIV-5164: Fix page title * NFDIV-5164: Rename constant * NFDIV-4949: Remove duplicate entries for steps * NFDIV-4949: Remove duplicate entries for steps * NFDIV-5164: Add serve another way check back * NFDIV-5164: Revert unnecessary changes * NFDIV-4922: Fix generic error and label * NFDIV-4922: Add postal in the label * NFDIV-4949: Update content on email address page * NFDIV-5164 - Add link for progressing without address * NFDIV-5164 - Add link for progressing without address * NFDIV-4949: Add page for international address (#4459) * NFDIV-4949: Add page for international address * NFDIV-4949: Fix unit tests * Apply suggestion from @adamg-hmcts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * Update src/main/steps/applicant1/address-international/content.ts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * Update src/main/steps/applicant1/address-international/template.njk Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * NFDIV-4949: Reorder sequence file * NFDIV-4949: Remove duplicate entries for steps * NFDIV-4949: Remove duplicate entries for steps * NFDIV-4949: Update content on email address page * NFDIV-4949: Fix lint issue * Clean up typos * NFDIV-4949: Add international address guidance * NFDIV-4949: Revert previous commit about international guidance * NFDIV-4949: Update button label to the new design * NFDIV-4949: Revert use this address as agreed to continue label for button --------- Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> Co-authored-by: elis.davies <elis.davies@justice.gov.uk> * NFDIV-5164: Fix yarn lint * NFDIV-4993 - no respondent address - add address (#4502) * NFDIV-4993 - Draft changes * NFDIV-4993 - Tweaks to content * NFDIV-4993 - rename event * NFDIV-4993 - add link for serving outside UK * NFDIV-4993 - add autobind decorator * NFDIV-4993 - merge issues * NFDIV-4993 - resolve address issues * NFDIV-4993 - Rework address fields * NFDIV-4993 - Rework address fields * NFDIV-4993 - Fix variable name used to show conditional text on page * NFDIV-4993 - Remove changes made to international address page for respondent address * NFDIV-4922: Fix issues with cya page * NFDIV-5164: Refactor code * NFDIV-5164: Refactor logic to use applicant2Address * NFDIV-5164: Fix failing unit tests * Update src/main/steps/applicant1/hub-page/sole/soleTemplateSelector.test.ts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * Update src/main/steps/applicant1/hub-page/sole/soleTemplateSelector.test.ts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * Update src/main/steps/applicant1/hub-page/sole/soleTemplateSelector.test.ts Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> * NFDIV-5164: Fix issue with banner * NFDIV-5164: Fix content for address and documents required * Make links open in same tab * NFDIV-5164: Fix issue with no address content * NFDIV-5164: Fix the content issue * NFDIV-5164: Fix title heading * NFDIV-5164: Fix title background * NFDIV-5164: Refactor code to remove duplication * NFDIV-5164: Fix unit test * NFDIV-5164: Fix issue with content * NFDIV-5164: Fix issue with hub content * NFDIV-5164: Fix issue with international address * NFDIV-5164: Remove server papers another way content * NFDIV-5164: Fix unit tests * NFDIV-5164: Fix backward compatibility * NFDIV-5164: Update to run against correct backend PR * NFDIV-5164: Fix functional tests * NFDIV-5164: Fix issue with backward compatibility * NFDIV-5164: Fix functional test * NFDIV-5184 - Save and sign out changes for no respondent address service apps (#4539) * NFDIV-5184 - Draft changes * NFDIV-5184 - fixed lint issues * NFDIV-5184 - Save and signout fix * NFDIV-5197 - Allow citizen to withdraw pre-issue service application (#4540) * NFDIV-5197 - Allow citizen to withdraw pre-issue service application * NFDIV-5197 - reuse variable from common content * NFDIV-5197 - reuse variable from common content * NFDIV-5184 - Resolve unintentional overwrites due to merge --------- Co-authored-by: eliswyndavies <168655403+eliswyndavies@users.noreply.github.com> --------- Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com> Co-authored-by: pallavijustice <pallavi.saha@justice.gov.uk> Co-authored-by: elis.davies <elis.davies@justice.gov.uk> Co-authored-by: pallavijustice <159147694+pallavijustice@users.noreply.github.com> Co-authored-by: eliswyndavies <168655403+eliswyndavies@users.noreply.github.com>
* Tweaks to no respondent address logic * Update backend PR references * Correct url in search gov records test * Include no respondents address options flow in search gov E2E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-5200
Before merging a pull request make sure that:
If this ticket will have any visible impact on users and is not behind a feature toggle, make sure that:
Note that bug fixes, dependency updates and technical tasks do not directly impact the user experience and can be merged without QA and PO review.
If this user story cannot be immediately merged find a way to put it behind a feature toggle and get it merged.