Open
Conversation
This reverts commit 5c6d5c1.
yogesh-hullatti
previously approved these changes
Feb 26, 2026
src/functionalTest/java/uk/gov/hmcts/dm/functional/DocumentMetadataDeletionIT.java
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/dm/service/DocumentMetadataDeletionService.java
Show resolved
Hide resolved
Contributor
Plan Result (aat) |
Contributor
Plan Result (prod) |
MichaelJacob21012
previously approved these changes
Mar 5, 2026
BenNzewi
reviewed
Mar 5, 2026
BenNzewi
left a comment
BenNzewi
left a comment
There was a problem hiding this comment.
Should we include the ITs to cover the edge cases when
- Call to Em-Anno delete endpoint returns failure/error. Do not call Em-NPA delete endpoint.
- Call to Em-Anno delete endpoint returns success but the call to Em-NPA delete endpoint returns failure/error.
yogesh-hullatti
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EM-6923
– Document Delete EM Integration
Currently, a conditional service is used to avoid initiating IDAM and its dependencies locally.
A functional test has been added as a smoke test to verify the connection to EM services, as the IDAM and S2S users were newly created for this integration. Once the integration is stable, this test can be removed.