Skip to content

testing new pipeline steps#2716

Draft
JakeM-Kainos wants to merge 7 commits intomasterfrom
DTSPO-28968
Draft

testing new pipeline steps#2716
JakeM-Kainos wants to merge 7 commits intomasterfrom
DTSPO-28968

Conversation

@JakeM-Kainos
Copy link
Copy Markdown
Contributor

@JakeM-Kainos JakeM-Kainos commented Jan 12, 2026

Jira link

See PROJ-XXXXXX

Change description

Testing done

Security Vulnerability Assessment

CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?

  • Yes
  • No

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

Link to Terraform Plan

https://tfplan-viewer.hmcts.net/azure-platform-terraform/2716

🤖AEP PR SUMMARY🤖

  • azure_pipeline.yaml: Added a new variables section under the resources block, initializing timeoutInMinutes. ⏳

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 12, 2026

Improvements:

  1. Default value for timeoutInMinutes:

    • There is no default value set for timeoutInMinutes. You should provide a default to avoid potential undefined behavior. For example:
      yaml
      variables:
      • name: timeoutInMinutes
        value: 60 # Set a sensible default
      
      
  2. Typing and validation:

    • The value of timeoutInMinutes should ideally be checked or validated elsewhere in the pipeline to ensure it is a positive integer. Add comments to indicate expected value type and behavior.
  3. Version controlling resources:

    • The hmcts/cnp-azuredevops-libraries reference uses refs/heads/master. For better stability and predictable builds, consider using a specific tag or commit hash instead:
      ref: refs/tags/v1.2.3
  4. Environment-specific variable grouping (if applicable):

    • If this pipeline is used for multiple environments, consider parameterizing timeoutInMinutes through pipeline parameters instead of variables:
      parameters:
        - name: timeoutInMinutes
          type: int
          default: 60
          displayName: \"Pipeline Timeout (minutes)\"
  5. Documentation:

    • If timeoutInMinutes has a specific purpose, add a comment to explain its role to improve maintainability:
      # Specifies the maximum time (in minutes) the pipeline will wait before timing out
      - name: timeoutInMinutes
        value: 60

Notes:

  • These modifications don't directly impact the operational cost, but using a default fallback can prevent inefficient resource usage due to undefined timeout settings.
  • No measurable impact on carbon usage, as pipeline adjustments reduce uncertainty rather than computational overhead.

@JakeM-Kainos JakeM-Kainos added the OverrideMasterCheck Label for overriding master check on ADO pipeline label Jan 13, 2026
@hmcts-platform-operations
Copy link
Copy Markdown

hmcts-platform-operations commented Jan 14, 2026

Tip

✅ master branch build is now passing!

Build: #apply - Azure Platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OverrideMasterCheck Label for overriding master check on ADO pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants