Golden Path Step 9

[remerdy1]

Create Frontdoor entry for Golden Path Step 9

Checklist

• commit messages are meaningful and follow good commit message guidelines
• README and other documentation has been updated / added (if needed)
• tests have been updated / new tests has been added (if needed)
• Does this PR introduce a breaking change

Link to Terraform Plan

https://tfplan-viewer.hmcts.net/azure-platform-terraform/2669

🤖AEP PR SUMMARY🤖

• environments/sbox/sbox.tfvars 🚀
  • Added a new frontend configuration for the product labs-goldenpath-remythompson.
  • Included details such as name, custom_domain, dns_zone_name, backend_domain, and certificate_name.
  • Set disabled_rules to an empty map for this new frontend.

[github-actions]

Code Quality:

1. Consistency in Indentation: Ensure consistent indentation to improve readability:
   hcl
   frontends = [
   {
   product = "labs-goldenpath-remythompson"
   name = "labs-goldenpath-remythompson"
   custom_domain = "labs-goldenpath-remythompson.sandbox.platform.hmcts.net"
   dns_zone_name = "sandbox.platform.hmcts.net"
   backend_domain = ["firewall-sbox-int-palo-labsgoldenpathremythompson.uksouth.cloudapp.azure.com"]
   certificate_name = "wildcard-sandbox-platform-hmcts-net"
   disabled_rules = {}
   },
   {
   product = "idam"
   name = "idam-web-public"

Security:

2. Custom Domain Validation: Validate that custom_domain values are verified and controlled by your organization to avoid DNS hijacking risks.
3. Empty disabled_rules Key: Consider explicitly checking if this key is required or leaving it out if not. If dynamic configuration is needed, create a robust mechanism to populate it securely.

Best Practices:

4. Variable Naming Consistency: Ensure product, name, and other parameter values are consistent across all entries for easier maintenance. For instance, verifying no trailing spaces or formatting differences:

   • Example: \"labs-goldenpath-remythompson\" is consistently used.

5. Documentation: Add comments explaining the purpose of this configuration block, especially for less obvious fields like backend_domain.

Cost:

6. Review Resource Usage: The field backend_domain points to Azure services (uksouth.cloudapp.azure.com). Double-check resource consumption settings such as active instances or scaling configurations to avoid unexpected charges. Depending on scaling, this could increase costs by £50-£500/month per underestimated resource.

Carbon Usage:

7. Region Consideration for Carbon Footprint: The use of "uksouth" for Azure resources may have a higher or lower carbon footprint compared to alternative locations—evaluate greener regions if feasible without impacting performance requirements.

Suggested Minor Adjustment:

• Simplify and remove redundant information in the product and name fields if applicable:

  frontends = [
    {
      product = \"labs-goldenpath\"
      name = \"remythompson\"

Prioritize cleaning up redundant elements and documenting settings to ensure maintainability and security.