Fix a bug in the handling of C strings.#6
Open
tmroeder wants to merge 1 commit intohlslibs:masterfrom
Open
Conversation
The while loop will never exit due to the check `while(str)`, since str will never become null by increment. This should be checking the character pointed to by str.
|
Can I ask you please, why for ac_int , the width of the division result is the addition of the divided and dividor widths (W1+W2) as written in the pdf, table #9? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The while loop will never exit due to the check
while(str), since strwill never become null by increment. This should be checking the
character pointed to by str.