Skip to content

fix issue#3 Store GOBJ: Extended presence flags#8

Open
chmcl95 wants to merge 3 commits intohlorenzi:masterfrom
chmcl95:GOBJ
Open

fix issue#3 Store GOBJ: Extended presence flags#8
chmcl95 wants to merge 3 commits intohlorenzi:masterfrom
chmcl95:GOBJ

Conversation

@chmcl95
Copy link
Contributor

@chmcl95 chmcl95 commented Apr 12, 2022

these changes "Copy" column of "Values for padding" to ✔(means supporting).
https://wiki.tockdom.com/wiki/Extended_presence_flags/Software_Overview#KMP_Tools

Wiimm claims KMP editing tools "must store padding of GOBJ section values".
https://wiki.tockdom.com/wiki/Extended_presence_flags/Implementation_Hints#Reference-Id_.28Padding.29
It's means this tool must store "ExtraData" of "GOBJ".

thus I changed store ExtraDatas of GOBJ.
and I expand it to any sections(KTPT, ENPT, ENPH etc...) ExtraData.
It's for other sections expand in the future.

@chmcl95
Copy link
Contributor Author

chmcl95 commented Apr 12, 2022

If you only hope fix issue #3 .
needs add these lines.

let extraDatas = []

extraDatas.push({ id: sectionId, vaule: extraData })

kmp.extraDatas = kmpData.extraDatas

scetionMagicStr = "GOBJ"

extraData = this.extraDatas.find(s => s.id == scetionMagicStr)
w.writeUInt16(extraData.vaule)

cloned.extraDatas = this.extraDatas

I extend it as any sections(KTPT, ENPT, ENPH etc...).
It's for other sections extends in the future.

tbh, idk other section expand happens actually ...
I suppose it's happen.
this is why I expand it.

@hlorenzi hlorenzi force-pushed the master branch 7 times, most recently from 56930cb to 54d84e9 Compare June 25, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant