Open
Conversation
Edited package.json so it is no longer forcing Electron to build a Windows Executable. Also changed controls so anything that requires pressing the alt key will now require pressing the Shift key. This is because Linux (maybe only Ubuntu and derivatives?) uses alt and clicking and dragging to move the window around. All control hints for actions using the Alt key have been updated to reflect this change.
Grabbed the highest res image from icon.ico in 'build/' and made it a separate .png image so electron won't throw errors trying to grab the .ico file for the Windows Version.
Edited package.json to provide a command for making Windows executables (on non-Windows platforms) and executables for non-Windows platforms. Updated Readme to reflect the changes made in this fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty self-explanatory, this PR makes a few minor changes that fixes issues when the program is run on Linux. This includes changing the controls so all actions that use the Alt key use Shift instead, since on my distro (Linux Mint 22) Alt-clicking and Alt-dragging moves the window instead of creating and connecting points. I assume this works the same on other distros.
My fork also makes changes to package.json so bulding can be done using either
dist-winordist-unix(dist has been deprecated in favour of this), dist-win is the old behaviour of dist where electron is forced to build Windows executables and dist-unix is a new command that builds for the operating system you are running on. The highest resolution image in icon.ico has also been saved as a separate png file for Linux targets.If this PR is ever approved and merged, keep in mind I updated the readme so you may either want to replace it with the original or edit the new one so it's consistent with this repository, that includes removing "(Fork for Linux)" from the title, changing the Releases section hyperlink back to what it originally was and removing the "Changes made in this fork" section. You can optionally remove the Building Executables section if you'd like, idc either way.