Fix: iOS - Ensure node name is included in onPanEnd and onRotationEnd #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acks - Fixed serializeLocalTransformation to handle nil nodes gracefully - Changed transform array from optional to non-optional Float array - Changed node name from optional to non-optional String - Store node reference before clearing panningNode to prevent nil access - Only invoke onPanEnd/onRotationEnd if node exists This fixes the issue where call.arguments["name"] was nil, causing the Dart callback handler to fail silently in the catch block.
This was referenced Nov 10, 2025
nikkon404
force-pushed
the
fix/pan-rotation-end-node-name
branch
from
e5367f1 to
9449e0a
Compare
- Added defensive null check for name before creating transformMap - Only invoke callback if name exists (consistent with iOS fix) - Prevents potential crashes when name is null from nodeData["name"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…acks
This fixes the issue where call.arguments["name"] was nil, causing the Dart callback handler to fail silently in the catch block.