fix: Prevent #89 from overriding --hl-node-compliant subscriptions #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprites0
changed the title
Collaborator
Author
|
Just tested with both setup (with & without the flag). Since it's tricky to test this without unwinding the node, I'll add fully automated test in separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Fix for
--hl-node-compliantmode on the latest version (nb-20251011).Not affected if this flag is not used.
Affected RPC:
eth_subscribe[type=logs](WebSocket) when running with--hl-node-compliant.Details
Regression from #89 caused
eth_subscribeto be overridden after the--hl-node-compliantlogic, resulting in logs from system transactions being returned.This patch also addresses a previously unreachable bug (6c3ed63), which becomes reachable after the main fix.