feat(breaking): Use custom header format (HlHeader) #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprites0
force-pushed
the
breaking/hl-header
branch
from
0a12c02 to
47aaad6
Compare
sprites0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves performance regression of #79 which was much more severe than expected. Now it uses HlHeader (Header + system_tx_count and logs_bloom with system transaction receipts) for internal storage.
Since this is a breaking change, a migrator to upgrade the DB to use custom header format is included, and will be started when the node starts. It took roughly 8~10 minutes in my machine for the latest block.
Also updated --hl-node-compliant to use the new field instead of enumerating all transactions.