Skip to content

Conversation

@CAG2Mark
Copy link
Contributor

See #369

@LPTK
Copy link
Contributor

LPTK commented Jan 15, 2026

Oh, I didn't realize the handler refactor PR was made against the remove-scope-hacks branch. We should have changed that before the merge.

By the way, your rebased commit does not compile.

rec(l.body)(using isLinear = false) |> merge
applyBlock(l.rest)
case Assign(lhs, rhs, rest) =>
println("assign: " + lhs + " = " + rhs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you're printing debugging information and will presumably remove the printing later. Why not use the tracing debug mechanism, so we can enable debugging of the lifter (eg with :dl) whenever needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll consider adding it

Comment on lines 21 to 26
import hkmc2.ScopeData.ScopedObject.Top
import hkmc2.ScopeData.ScopedObject.Companion
import hkmc2.ScopeData.ScopedObject.ClassCtor
import hkmc2.ScopeData.ScopedObject.Func
import hkmc2.ScopeData.ScopedObject.Loop
import hkmc2.ScopeData.ScopedObject.ScopedBlock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import hkmc2.ScopeData.ScopedObject.Top
import hkmc2.ScopeData.ScopedObject.Companion
import hkmc2.ScopeData.ScopedObject.ClassCtor
import hkmc2.ScopeData.ScopedObject.Func
import hkmc2.ScopeData.ScopedObject.Loop
import hkmc2.ScopeData.ScopedObject.ScopedBlock
import hkmc2.ScopeData.ScopedObject.*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My IDE kept adding these when I was autocompleting match statements, so I've just manually removed usages of these.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Which IDE do you use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just vscode with the nornal Scala extension

@CAG2Mark
Copy link
Contributor Author

Remaining tasks:

  • Add back handler paths (so we are allowed to lift classes that extend handler-related classes)
  • Lift objects

Comment on lines 21 to 26
import hkmc2.ScopeData.ScopedObject.Top
import hkmc2.ScopeData.ScopedObject.Companion
import hkmc2.ScopeData.ScopedObject.ClassCtor
import hkmc2.ScopeData.ScopedObject.Func
import hkmc2.ScopeData.ScopedObject.Loop
import hkmc2.ScopeData.ScopedObject.ScopedBlock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Which IDE do you use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants