-
Notifications
You must be signed in to change notification settings - Fork 40
Lifter revamp #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: hkmc2
Are you sure you want to change the base?
Lifter revamp #384
Conversation
0d1e547 to
156d657
Compare
|
Oh, I didn't realize the handler refactor PR was made against the By the way, your rebased commit does not compile. |
| rec(l.body)(using isLinear = false) |> merge | ||
| applyBlock(l.rest) | ||
| case Assign(lhs, rhs, rest) => | ||
| println("assign: " + lhs + " = " + rhs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you're printing debugging information and will presumably remove the printing later. Why not use the tracing debug mechanism, so we can enable debugging of the lifter (eg with :dl) whenever needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll consider adding it
| import hkmc2.ScopeData.ScopedObject.Top | ||
| import hkmc2.ScopeData.ScopedObject.Companion | ||
| import hkmc2.ScopeData.ScopedObject.ClassCtor | ||
| import hkmc2.ScopeData.ScopedObject.Func | ||
| import hkmc2.ScopeData.ScopedObject.Loop | ||
| import hkmc2.ScopeData.ScopedObject.ScopedBlock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| import hkmc2.ScopeData.ScopedObject.Top | |
| import hkmc2.ScopeData.ScopedObject.Companion | |
| import hkmc2.ScopeData.ScopedObject.ClassCtor | |
| import hkmc2.ScopeData.ScopedObject.Func | |
| import hkmc2.ScopeData.ScopedObject.Loop | |
| import hkmc2.ScopeData.ScopedObject.ScopedBlock | |
| import hkmc2.ScopeData.ScopedObject.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My IDE kept adding these when I was autocompleting match statements, so I've just manually removed usages of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Which IDE do you use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just vscode with the nornal Scala extension
|
Remaining tasks:
|
| import hkmc2.ScopeData.ScopedObject.Top | ||
| import hkmc2.ScopeData.ScopedObject.Companion | ||
| import hkmc2.ScopeData.ScopedObject.ClassCtor | ||
| import hkmc2.ScopeData.ScopedObject.Func | ||
| import hkmc2.ScopeData.ScopedObject.Loop | ||
| import hkmc2.ScopeData.ScopedObject.ScopedBlock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Which IDE do you use?
See #369