Skip to content

Conversation

@r0bc94
Copy link

@r0bc94 r0bc94 commented Jan 17, 2021

This PR intruduces the pathlib library to handle filepaths.

The obvious adavantage of this is, that now the path handling is transparent between different operation systems (such as windows and linux). This also makes the script work on windows systems (if ghostscript is installed and the path to the gswin64 binary is registered in %PATH%).

Note: Since im currently not able to test it in linux, I've only tested this changes in windows. Before merging you should therefore check, if this script still works fine in linux.

Fixes #4

@r0bc94 r0bc94 force-pushed the use_pathlib_path_handling branch from 6720aa5 to 9f32a39 Compare January 17, 2021 20:47
@r0bc94 r0bc94 force-pushed the use_pathlib_path_handling branch from 9f32a39 to 9ebeaf9 Compare January 17, 2021 20:49
@r0bc94 r0bc94 changed the base branch from develop to master January 17, 2021 20:49
@r0bc94
Copy link
Author

r0bc94 commented Jan 17, 2021

Sorry about the forced updates, I actually missed that there is a develop branch, so I rebased my branch to match the develop's state. However it seems that your master branch is actually some commit before your develop branch which confused me a bit :). This state should be fine now.

However, I would fix the issue that your develop branch is before master. If you fixed it please let me know, which branch I should use as a target for this PR.

@r0bc94
Copy link
Author

r0bc94 commented Jan 17, 2021

I also just disabled the checks for invalid characters in the input- and output's filename since i'm not sure if this check is still needed in order for ghostscript to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specifying a Different Path for the Input Files

1 participant