[iOS] Change from Device orientation to App UI orientation for PreviewLayer#195
Open
Crudling wants to merge 1 commit intohjam40:masterfrom
Open
Conversation
…ether to "flip" the camera. This fixes issues with apps that are locked to certain orientations in info.plist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Currently on iOS the CameraViewMaui.cs - LayOutSubviews() checks the physical device's orientation and "flips" the camera feed to landscape/portrait mode accordingly. For an app that is locked to portrait-mode this means that the app itself will remain in portrait mode but the camera feed will flip to landscape mode when the phone is "flipped".
How this PR fixes it:
This PR changes the code in LayOutsubviews() to check the app's orientation - locking the camera feed to the same orientation as the app. The camera feed now respects the orientations set in Info.plist.
Code quality:
The code used is taken from the Maui Communitytoolkit's implementation of camera feed orientations, and tested on a physical device (iPhone 12 pro) to make sure it works.