-
Notifications
You must be signed in to change notification settings - Fork 58
Fix: Terms of Service link not redirecting on Become a Host page #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix: Terms of Service link not redirecting on Become a Host page #158
Conversation
…st page - Changed non-functional anchor tags to React Router Link components - Updated href='#' to proper route to='/terms' - Ensures users can now access Terms of Service page from Become a Host page footer Resolves hitesh-kumar123#156
✅ Deploy Preview for smartrentsystem ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR resolves issue #156 by fixing non-functional Terms of Service and Host Policies links on the Become a Host page, while significantly enhancing the host onboarding experience with comprehensive policy documentation and mandatory terms acceptance.
Changes:
- Created a new dedicated Host Policies page with 12 comprehensive policy sections covering listing standards, pricing, communication, legal compliance, and more
- Enhanced BecomeHost page with mandatory terms acceptance checkbox that disables the "Publish listing" button until accepted
- Updated Terms page to include prominent links to the new Host Policies and additional resources like Safety Center and Help Center
- Added proper routing for the new
/host-policiespage
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/App.js | Added route configuration for the new Host Policies page |
| frontend/src/pages/HostPolicies.jsx | Created comprehensive Host Policies page with 12 policy sections, related resources, and professional UI/UX |
| frontend/src/pages/BecomeHost.jsx | Added terms acceptance state, mandatory checkbox on final step, disabled publish button until terms accepted, and replaced non-functional href="#" links with proper React Router Links |
| frontend/src/pages/Terms.jsx | Added Host Policies card at top of related resources section and additional links to Safety Center and Help Center |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frontend/src/pages/HostPolicies.jsx
Outdated
| <h3 className="text-xl font-semibold text-neutral-700 mt-6 mb-3">Service Fees</h3> | ||
| <p className="mb-6"> | ||
| Smart Rent System charges a service fee of 3% on each booking. This fee is automatically deducted from your payout and covers payment processing, customer support, and platform maintenance. | ||
| </p> |
Copilot
AI
Jan 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a discrepancy between the PR description and the implementation. The PR description states the platform fee is 5%, but the code specifies a 3% service fee. This inconsistency should be resolved by either updating the documentation to match the actual fee or correcting the fee amount.
frontend/src/pages/BecomeHost.jsx
Outdated
| </p> | ||
| </label> | ||
| </div> | ||
| {!termsAccepted && currentStep === totalSteps && ( |
Copilot
AI
Jan 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition checking currentStep === totalSteps is redundant here since this entire block is already wrapped in a conditional that checks currentStep === totalSteps on line 1235. The inner condition can be simplified to just !termsAccepted.
…section Major enhancements to justify 'hard' label while staying in scope: 1. Interactive Table of Contents - Sticky sidebar with smooth scroll navigation - Active section highlighting as user scrolls - Quick jump to any section with one click - Mobile responsive design 2. Enhanced Host Responsibilities Section - Dedicated section (Section 5) specifically for hosts - Prominent 'For Hosts' badge for easy identification - Detailed host obligations and requirements - Visual alerts for important host information - Directly relevant to Become a Host page context 3. Improved UX Features - Smooth scroll behavior with scroll-mt-24 offset - URL hash support (#section-id) for deep linking - Active section tracking on scroll - Gradient header with icon - Last updated date prominently displayed 4. Visual Enhancements - Important notice callout box - Color-coded alert boxes (info, warning) - Host-specific CTA banner linking to Become a Host - Professional grid layout with sidebar - Improved typography and spacing 5. Accessibility Improvements - Semantic HTML with proper heading hierarchy - Keyboard navigable table of contents - ARIA-friendly scroll behavior - Clear visual indicators for interactive elements This comprehensive enhancement transforms the basic Terms page into an advanced, user-friendly resource that specifically addresses host concerns referenced from the Become a Host page. Resolves hitesh-kumar123#156
3e1ca46 to
8de6dd5
Compare
|
@hitesh-kumar123 please review |
|
add before after image |
Screen.Recording.2026-01-25.103245.mp4
Screen.Recording.2026-01-25.104003.mp4@hitesh-kumar123 please review and so sorry for not adding changes screenshot in the PR |
|
@hitesh-kumar123 please review |
|
@hitesh-kumar123 please reivew !!!!! |
|
@hitesh-kumar123 please review |
|
@hitesh-kumar123 where are you bro please see these |
|
@hitesh-kumar123 please review these one |
|
Hey @hitesh-kumar123 please review and asisgned me an open issue its almost so many days does but you didnt merge |
|
@hitesh-kumar123 please review bhai |
🎯 Overview
Fixes #156 - Resolves non-functional Terms of Service and Host Policies links on the Become a Host page while significantly enhancing the host onboarding experience with comprehensive policy documentation and mandatory terms acceptance.
Problem Statement
On the
/host/become-a-hostpage:href="#"with no navigation✨ Solution Implemented
This PR transforms a simple link fix into a comprehensive host onboarding enhancement:
Created Dedicated Host Policies Page
New File:
frontend/src/pages/HostPolicies.jsx(550+ lines)12 Comprehensive Policy Sections:
Professional UI/UX Features:
Enhanced BecomeHost Page with Terms Acceptance
Modified File:
frontend/src/pages/BecomeHost.jsxFinal Step Features:
Enhanced Terms Page
@hitesh-kumar123 please review!