refactor(core): drop Python 2 compatibility code #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes Python 2 compatibility code from the pycouchdb library, modernizing the codebase to work exclusively with Python 3. The refactor eliminates conditional imports, version checking, and legacy string/unicode type handling.
- Removes
__future__imports that were required for Python 2 compatibility - Eliminates Python version checking and conditional imports for urllib modules
- Updates documentation to reflect the removal of Python 2 support
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/test_integration.py | Removes __future__ imports for print_function and unicode_literals |
| pycouchdb/utils.py | Removes Python version checking and conditional imports, simplifies urllib imports |
| pycouchdb/resource.py | Removes unicode_literals __future__ import |
| README.md | Updates CI badge branch reference and removes mention of Python 3 compatibility issues |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # py-couchdb | ||
|
|
||
| [](https://github.com/histrio/py-couchdb/actions/workflows/main.yml) | ||
| [](https://github.com/histrio/py-couchdb/actions/workflows/main.yml) |
There was a problem hiding this comment.
The CI badge branch reference changed from 'no-py2' to 'master', but this appears unrelated to dropping Python 2 compatibility. Consider using a more appropriate branch name or verify this change is intentional for the refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.