Skip to content

feat: Implemented validators for Stacks signer message predicates with comprehensive passing tests #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Marvy247 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: Implemented validators for Stacks signer message predicates with comprehensive passing tests #738

Marvy247 wants to merge 1 commit into from

Conversation

@Marvy247
Copy link

@Marvy247 Marvy247 commented Jan 8, 2026 

 - Added validation for StacksSignerMessagePredicate with pubkey and timestamp checks
 - Validate secp256k1 public keys (compressed 33 bytes, uncompressed 65 bytes)
 - Validate timestamps are non-zero and before year 2100
 - Implement pubkey evaluation in evaluate_stacks_predicate_on_non_consensus_events
 - Added comprehensive test suite covering valid/invalid pubkeys and timestamps
 - Resolve TODOs for signer message predicate validation and evaluation

 This change improves security by preventing invalid signer public keys
 and timestamps from entering the system during predicate validation.
 @rafaelcr @CharlieC3 @MicaiahReid @hugoclrd

@Marvy247
feat: implement validators for Stacks signer message predicates
d1a5cab 
     - Add validation for StacksSignerMessagePredicate with pubkey and timestamp checks
     - Validate secp256k1 public keys (compressed 33 bytes, uncompressed 65 bytes)
     - Validate timestamps are non-zero and before year 2100
     - Implement pubkey evaluation in evaluate_stacks_predicate_on_non_consensus_events
     - Add comprehensive test suite covering valid/invalid pubkeys and timestamps
     - Resolve TODOs for signer message predicate validation and evaluation

     This change improves security by preventing invalid signer public keys
     and timestamps from entering the system during predicate validation.
@Marvy247
Copy link
Author

Marvy247 commented Jan 12, 2026

@rafaelcr @CharlieC3 @MicaiahReid @hugoclrd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Marvy247