[ BugFix ] adds missing dependency#210
Conversation
9633b7b to
7f5c71c
Compare
|
I tried adding |
|
I think this is the result of #125. I think maybe the better solution would just wrap the |
|
I think I was wrong about where the issue lives. It's here. The class on which we're relying does in fact exist. It's just that the maintainers of that package are relying on a class that only lives in their dev dependencies. |
|
We also just ran into issues when trying to upgrade to See the Symfony docs for PhpDocExtractor:
So, making this an optional dependency as @inxilpro suggested might be a good trade-off, probably combined with a brief update in the docs about this optional convenience feature :) |
There’s a bug in our dependencies
Our Cloud deployments are blowing up because of an unmet dep (using --no-dev).
We’re not finding two classes that are being used in the VerbsServiceProvider
They’re from a package called phpdocumentor/reflection-docblock which is a dep of symfony/serializer, but it’s been moved into their require-dev. We should require this package explicitly to fix it.