Created a single file input & Fixed problem with change listener#4
Open
abritopach wants to merge 4 commits intohinddeep:masterfrom
Open
Created a single file input & Fixed problem with change listener#4abritopach wants to merge 4 commits intohinddeep:masterfrom
abritopach wants to merge 4 commits intohinddeep:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @hinddeep
Thank you very much for your work.
I've solved some problems and refactored some of the code.
Each time fileSelector is called, an input with the same name is being created. The code has been modified to create a single input.
Fixed problem with the listener change. It is executed more than once so the same element is selected in duplicate or triplicate.
Solved problem when ext is * (Allow any file type).
Deleted dist folder (no need to upload to repo).
If you have any questions, please let me know.
If you think I can help you to keep improving this plugin.
Greetings,