Implemented [local] named pipe transport support.#2
Open
lor3 wants to merge 1 commit intohikalkan:masterfrom
Open
Implemented [local] named pipe transport support.#2lor3 wants to merge 1 commit intohikalkan:masterfrom
lor3 wants to merge 1 commit intohikalkan:masterfrom
Conversation
Contributor
Author
|
👍🏻 |
Owner
|
Hi, Your effort is valuable. But I also did implemented NamedPipes as communication channel. But saw that it's slower than TCP (especially when using mutexes to control read/write to named pipe). And then I removed it since TCP is more generic and it has no resctriction to be in same computer like named pipes. So, I think to not include named pipes to SCS. If you really like, you may publish it as a seperated library. So, anyone can add reference to your library and use it in SCS. Thanks a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you are interested in this, in my tests (Windows 8.1/64-bit) TCP connections were around 50% faster which was a bit of a surprise, but this may not be the case for older Windows versions.
Could be made into an external module if some Scs internals were made public.